chore: fix issues reported by go vet (#2952)

<!-- please provide a detailed description of the changes made in this
pull request. -->
Passing `go vet` is the minimum level of code quality for a go project.
This is addressed here for the full mono-repo. Mainly trivial changes,
except for a few `copy lock` issues which could be more meaningful (kept
for a separate pull request).

Addresses #2954 (but not sufficient to close it yet).

Hint for reviewers: it's easier to review each commit individually.
 
<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

gno.land/pkg/gnoweb/gnoweb.go

@@ -476,7 +476,7 @@ func handleNotFound(logger *slog.Logger, app gotuna.App, cfg *Config, path strin
 	// decode path for non-ascii characters
 	decodedPath, err := url.PathUnescape(path)
 	if err != nil {
-		logger.Error("failed to decode path", err)
+		logger.Error("failed to decode path", "error", err)
 		decodedPath = path
 	}
 	w.WriteHeader(http.StatusNotFound)
@@ -491,7 +491,7 @@ func writeError(logger *slog.Logger, w http.ResponseWriter, err error) {
 	if details := errors.Unwrap(err); details != nil {
 		logger.Error("handler", "error", err, "details", details)
 	} else {
-		logger.Error("handler", "error:", err)
+		logger.Error("handler", "error", err)
 	}
 
 	// XXX: writeError should return an error page template.

gno.land/pkg/sdk/vm/builtins.go

@@ -42,15 +42,15 @@ func (bnk *SDKBanker) TotalCoin(denom string) int64 {
 
 func (bnk *SDKBanker) IssueCoin(b32addr crypto.Bech32Address, denom string, amount int64) {
 	addr := crypto.MustAddressFromString(string(b32addr))
-	_, err := bnk.vmk.bank.AddCoins(bnk.ctx, addr, std.Coins{std.Coin{denom, amount}})
+	_, err := bnk.vmk.bank.AddCoins(bnk.ctx, addr, std.Coins{std.Coin{Denom: denom, Amount: amount}})
 	if err != nil {
 		panic(err)
 	}
 }
 
 func (bnk *SDKBanker) RemoveCoin(b32addr crypto.Bech32Address, denom string, amount int64) {
 	addr := crypto.MustAddressFromString(string(b32addr))
-	_, err := bnk.vmk.bank.SubtractCoins(bnk.ctx, addr, std.Coins{std.Coin{denom, amount}})
+	_, err := bnk.vmk.bank.SubtractCoins(bnk.ctx, addr, std.Coins{std.Coin{Denom: denom, Amount: amount}})
 	if err != nil {
 		panic(err)
 	}

gno.land/pkg/sdk/vm/keeper_test.go

@@ -81,7 +81,7 @@ func TestVMKeeperOrigSend1(t *testing.T) {
 
 	// Create test package.
 	files := []*std.MemFile{
-		{"init.gno", `
+		{Name: "init.gno", Body: `
 package test
 
 import "std"
@@ -126,7 +126,7 @@ func TestVMKeeperOrigSend2(t *testing.T) {
 
 	// Create test package.
 	files := []*std.MemFile{
-		{"init.gno", `
+		{Name: "init.gno", Body: `
 package test
 
 import "std"
@@ -180,7 +180,7 @@ func TestVMKeeperOrigSend3(t *testing.T) {
 
 	// Create test package.
 	files := []*std.MemFile{
-		{"init.gno", `
+		{Name: "init.gno", Body: `
 package test
 
 import "std"
@@ -224,7 +224,7 @@ func TestVMKeeperRealmSend1(t *testing.T) {
 
 	// Create test package.
 	files := []*std.MemFile{
-		{"init.gno", `
+		{Name: "init.gno", Body: `
 package test
 
 import "std"
@@ -268,7 +268,7 @@ func TestVMKeeperRealmSend2(t *testing.T) {
 
 	// Create test package.
 	files := []*std.MemFile{
-		{"init.gno", `
+		{Name: "init.gno", Body: `
 package test
 
 import "std"
@@ -312,7 +312,7 @@ func TestVMKeeperOrigCallerInit(t *testing.T) {
 
 	// Create test package.
 	files := []*std.MemFile{
-		{"init.gno", `
+		{Name: "init.gno", Body: `
 package test
 
 import "std"
@@ -363,7 +363,7 @@ func TestVMKeeperRunSimple(t *testing.T) {
 	env.acck.SetAccount(ctx, acc)
 
 	files := []*std.MemFile{
-		{"script.gno", `
+		{Name: "script.gno", Body: `
 package main
 
 func main() {
@@ -402,7 +402,7 @@ func testVMKeeperRunImportStdlibs(t *testing.T, env testEnv) {
 	env.acck.SetAccount(ctx, acc)
 
 	files := []*std.MemFile{
-		{"script.gno", `
+		{Name: "script.gno", Body: `
 package main
 
 import "std"
@@ -474,7 +474,7 @@ func TestVMKeeperReinitialize(t *testing.T) {
 
 	// Create test package.
 	files := []*std.MemFile{
-		{"init.gno", `
+		{Name: "init.gno", Body: `
 package test
 
 func Echo(msg string) string {

gnovm/pkg/gnomod/read.go

@@ -249,7 +249,7 @@ func (in *input) readToken() {
 
 			// Otherwise, save comment for later attachment to syntax tree.
 			in.endToken(_EOLCOMMENT)
-			in.comments = append(in.comments, modfile.Comment{in.token.pos, in.token.text, suffix})
+			in.comments = append(in.comments, modfile.Comment{Start: in.token.pos, Token: in.token.text, Suffix: suffix})
 			return
 		}
 

gnovm/tests/file.go

@@ -597,12 +597,12 @@ func (tb *testBanker) TotalCoin(denom string) int64 {
 
 func (tb *testBanker) IssueCoin(addr crypto.Bech32Address, denom string, amt int64) {
 	coins, _ := tb.coinTable[addr]
-	sum := coins.Add(std.Coins{{denom, amt}})
+	sum := coins.Add(std.Coins{{Denom: denom, Amount: amt}})
 	tb.coinTable[addr] = sum
 }
 
 func (tb *testBanker) RemoveCoin(addr crypto.Bech32Address, denom string, amt int64) {
 	coins, _ := tb.coinTable[addr]
-	rest := coins.Sub(std.Coins{{denom, amt}})
+	rest := coins.Sub(std.Coins{{Denom: denom, Amount: amt}})
 	tb.coinTable[addr] = rest
 }

misc/logos/cmd/logos.go

@@ -162,7 +162,7 @@ func makeTestPage() *logos.BufferedElemView {
 	// make a buffered page.
 	ts := makeTestString()
 	style := logos.DefaultStyle()
-	style.Padding = logos.Padding{2, 2, 2, 2}
+	style.Padding = logos.Padding{Left: 2, Top: 2, Right: 2, Bottom: 2}
 	style.Border = logos.DefaultBorder()
 	// TODO width shouldn't matter.
 	page := logos.NewPage(ts, 84, true, style)

tm2/pkg/amino/wellknown.go

@@ -210,7 +210,6 @@ func isJSONWellKnownType(rt reflect.Type) (wellKnown bool) {
 	default:
 		return false
 	}
-	return false
 }
 
 // Returns ok=false if nothing was done because the default behavior is fine (or if err).

tm2/pkg/bft/abci/example/kvstore/helpers.go

@@ -11,7 +11,7 @@ import (
 func RandVal(i int) abci.ValidatorUpdate {
 	pubkey := ed25519.GenPrivKey().PubKey()
 	power := random.RandUint16() + 1
-	v := abci.ValidatorUpdate{pubkey.Address(), pubkey, int64(power)}
+	v := abci.ValidatorUpdate{Address: pubkey.Address(), PubKey: pubkey, Power: int64(power)}
 	return v
 }
 

tm2/pkg/bft/abci/example/kvstore/persistent_kvstore.go

@@ -211,7 +211,7 @@ func (app *PersistentKVStoreApplication) execValidatorTx(tx []byte) (res abci.Re
 	}
 
 	// update
-	return app.updateValidator(abci.ValidatorUpdate{pubkey.Address(), pubkey, power})
+	return app.updateValidator(abci.ValidatorUpdate{Address: pubkey.Address(), PubKey: pubkey, Power: power})
 }
 
 // add, update, or remove a validator

tm2/pkg/bft/consensus/state.go

@@ -73,7 +73,7 @@ func (ti *timeoutInfo) GetHRS() cstypes.HRS {
 	if ti == nil {
 		return cstypes.HRS{}
 	} else {
-		return cstypes.HRS{ti.Height, ti.Round, ti.Step}
+		return cstypes.HRS{Height: ti.Height, Round: ti.Round, Step: ti.Step}
 	}
 }
 
@@ -746,13 +746,13 @@ func (cs *ConsensusState) handleTimeout(ti timeoutInfo, rs cstypes.RoundState) {
 	case cstypes.RoundStepNewRound:
 		cs.enterPropose(ti.Height, 0)
 	case cstypes.RoundStepPropose:
-		cs.evsw.FireEvent(cstypes.EventTimeoutPropose{cs.RoundState.GetHRS()})
+		cs.evsw.FireEvent(cstypes.EventTimeoutPropose{HRS: cs.RoundState.GetHRS()})
 		cs.enterPrevote(ti.Height, ti.Round)
 	case cstypes.RoundStepPrevoteWait:
-		cs.evsw.FireEvent(cstypes.EventTimeoutWait{cs.RoundState.GetHRS()})
+		cs.evsw.FireEvent(cstypes.EventTimeoutWait{HRS: cs.RoundState.GetHRS()})
 		cs.enterPrecommit(ti.Height, ti.Round)
 	case cstypes.RoundStepPrecommitWait:
-		cs.evsw.FireEvent(cstypes.EventTimeoutWait{cs.RoundState.GetHRS()})
+		cs.evsw.FireEvent(cstypes.EventTimeoutWait{HRS: cs.RoundState.GetHRS()})
 		cs.enterPrecommit(ti.Height, ti.Round)
 		cs.enterNewRound(ti.Height, ti.Round+1)
 	default:
@@ -1126,7 +1126,7 @@ func (cs *ConsensusState) enterPrecommit(height int64, round int) {
 	}
 
 	// At this point +2/3 prevoted for a particular block or nil.
-	cs.evsw.FireEvent(cstypes.EventPolka{cs.RoundState.GetHRS()})
+	cs.evsw.FireEvent(cstypes.EventPolka{HRS: cs.RoundState.GetHRS()})
 
 	// the latest POLRound should be this round.
 	polRound, _ := cs.Votes.POLInfo()
@@ -1143,7 +1143,7 @@ func (cs *ConsensusState) enterPrecommit(height int64, round int) {
 			cs.LockedRound = -1
 			cs.LockedBlock = nil
 			cs.LockedBlockParts = nil
-			cs.evsw.FireEvent(cstypes.EventUnlock{cs.RoundState.GetHRS()})
+			cs.evsw.FireEvent(cstypes.EventUnlock{HRS: cs.RoundState.GetHRS()})
 		}
 		cs.signAddVote(types.PrecommitType, nil, types.PartSetHeader{})
 		return
@@ -1155,7 +1155,7 @@ func (cs *ConsensusState) enterPrecommit(height int64, round int) {
 	if cs.LockedBlock.HashesTo(blockID.Hash) {
 		logger.Info("enterPrecommit: +2/3 prevoted locked block. Relocking")
 		cs.LockedRound = round
-		cs.evsw.FireEvent(cstypes.EventRelock{cs.RoundState.GetHRS()})
+		cs.evsw.FireEvent(cstypes.EventRelock{HRS: cs.RoundState.GetHRS()})
 		cs.signAddVote(types.PrecommitType, blockID.Hash, blockID.PartsHeader)
 		return
 	}
@@ -1170,7 +1170,7 @@ func (cs *ConsensusState) enterPrecommit(height int64, round int) {
 		cs.LockedRound = round
 		cs.LockedBlock = cs.ProposalBlock
 		cs.LockedBlockParts = cs.ProposalBlockParts
-		cs.evsw.FireEvent(cstypes.EventLock{cs.RoundState.GetHRS()})
+		cs.evsw.FireEvent(cstypes.EventLock{HRS: cs.RoundState.GetHRS()})
 		cs.signAddVote(types.PrecommitType, blockID.Hash, blockID.PartsHeader)
 		return
 	}
@@ -1186,7 +1186,7 @@ func (cs *ConsensusState) enterPrecommit(height int64, round int) {
 		cs.ProposalBlock = nil
 		cs.ProposalBlockParts = types.NewPartSetFromHeader(blockID.PartsHeader)
 	}
-	cs.evsw.FireEvent(cstypes.EventUnlock{cs.RoundState.GetHRS()})
+	cs.evsw.FireEvent(cstypes.EventUnlock{HRS: cs.RoundState.GetHRS()})
 	cs.signAddVote(types.PrecommitType, nil, types.PartSetHeader{})
 }
 
@@ -1591,7 +1591,7 @@ func (cs *ConsensusState) addVote(vote *types.Vote, peerID p2p.ID) (added bool,
 		return
 	}
 
-	cs.evsw.FireEvent(types.EventVote{vote})
+	cs.evsw.FireEvent(types.EventVote{Vote: vote})
 
 	switch vote.Type {
 	case types.PrevoteType:
@@ -1620,7 +1620,7 @@ func (cs *ConsensusState) addVote(vote *types.Vote, peerID p2p.ID) (added bool,
 				cs.LockedRound = -1
 				cs.LockedBlock = nil
 				cs.LockedBlockParts = nil
-				cs.evsw.FireEvent(cstypes.EventUnlock{cs.RoundState.GetHRS()})
+				cs.evsw.FireEvent(cstypes.EventUnlock{HRS: cs.RoundState.GetHRS()})
 			}
 
 			// Update Valid* if we can.

tm2/pkg/bft/consensus/wal_generator.go

@@ -77,7 +77,7 @@ func (w *heightStopWAL) Write(m walm.WALMessage) error {
 	}
 
 	w.logger.Debug("WAL Write Message", "msg", m)
-	err := w.enc.Write(walm.TimedWALMessage{fixedTime, m})
+	err := w.enc.Write(walm.TimedWALMessage{Time: fixedTime, Msg: m})
 	if err != nil {
 		panic(fmt.Sprintf("failed to encode the msg %v", m))
 	}

tm2/pkg/bft/types/params.go

@@ -36,8 +36,8 @@ var validatorPubKeyTypeURLs = map[string]struct{}{
 
 func DefaultConsensusParams() abci.ConsensusParams {
 	return abci.ConsensusParams{
-		DefaultBlockParams(),
-		DefaultValidatorParams(),
+		Block:     DefaultBlockParams(),
+		Validator: DefaultValidatorParams(),
 	}
 }
 
@@ -51,7 +51,7 @@ func DefaultBlockParams() *abci.BlockParams {
 }
 
 func DefaultValidatorParams() *abci.ValidatorParams {
-	return &abci.ValidatorParams{[]string{
+	return &abci.ValidatorParams{PubKeyTypeURLs: []string{
 		amino.GetTypeURL(ed25519.PubKeyEd25519{}),
 	}}
 }

tm2/pkg/crypto/hd/hdpath_test.go

@@ -17,7 +17,7 @@ func mnemonicToSeed(mnemonic string) []byte {
 	return bip39.NewSeed(mnemonic, defaultBIP39Passphrase)
 }
 
-func ExampleStringifyPathParams() {
+func ExampleNewParams() {
 	path := NewParams(44, 0, 0, false, 0)
 	fmt.Println(path.String())
 	path = NewParams(44, 33, 7, true, 9)
@@ -109,7 +109,7 @@ func TestParamsFromPath(t *testing.T) {
 	}
 }
 
-func ExampleSomeBIP32TestVecs() {
+func ExampleDerivePrivateKeyForPath() {
 	seed := mnemonicToSeed("barrel original fuel morning among eternal " +
 		"filter ball stove pluck matrix mechanic")
 	master, ch := ComputeMastersFromSeed(seed)

tm2/pkg/db/boltdb/boltdb.go

@@ -170,13 +170,13 @@ func (bdb *BoltDB) NewBatch() db.Batch {
 // It is safe to modify the contents of the argument after Set returns but not
 // before.
 func (bdb *boltDBBatch) Set(key, value []byte) {
-	bdb.ops = append(bdb.ops, internal.Operation{internal.OpTypeSet, key, value})
+	bdb.ops = append(bdb.ops, internal.Operation{OpType: internal.OpTypeSet, Key: key, Value: value})
 }
 
 // It is safe to modify the contents of the argument after Delete returns but
 // not before.
 func (bdb *boltDBBatch) Delete(key []byte) {
-	bdb.ops = append(bdb.ops, internal.Operation{internal.OpTypeDelete, key, nil})
+	bdb.ops = append(bdb.ops, internal.Operation{OpType: internal.OpTypeDelete, Key: key})
 }
 
 // NOTE: the operation is synchronous (see BoltDB for reasons)

tm2/pkg/db/memdb/mem_db.go

@@ -150,7 +150,7 @@ func (db *MemDB) NewBatch() dbm.Batch {
 	db.mtx.Lock()
 	defer db.mtx.Unlock()
 
-	return &internal.MemBatch{db, nil}
+	return &internal.MemBatch{DB: db}
 }
 
 // ----------------------------------------

tm2/pkg/p2p/switch.go

@@ -219,7 +219,7 @@ func (sw *Switch) OnStop() {
 	if t, ok := sw.transport.(TransportLifecycle); ok {
 		err := t.Close()
 		if err != nil {
-			sw.Logger.Error("Error stopping transport on stop: ", err)
+			sw.Logger.Error("Error stopping transport on stop: ", "error", err)
 		}
 	}
 

tm2/pkg/sdk/bank/keeper_test.go

@@ -133,7 +133,7 @@ func TestBankKeeper(t *testing.T) {
 	// validate coins with invalid denoms or negative values cannot be sent
 	// NOTE: We must use the Coin literal as the constructor does not allow
 	// negative values.
-	err = bank.SendCoins(ctx, addr, addr2, sdk.Coins{sdk.Coin{"FOOCOIN", -5}})
+	err = bank.SendCoins(ctx, addr, addr2, sdk.Coins{sdk.Coin{Denom: "FOOCOIN", Amount: -5}})
 	require.Error(t, err)
 }
 

tm2/pkg/sdk/baseapp.go

@@ -392,10 +392,6 @@ func (app *BaseApp) Query(req abci.RequestQuery) (res abci.ResponseQuery) {
 	default:
 		return handleQueryCustom(app, path, req)
 	}
-
-	msg := "unknown query path " + req.Path
-	res.Error = ABCIError(std.ErrUnknownRequest(msg))
-	return
 }
 
 func handleQueryApp(app *BaseApp, path []string, req abci.RequestQuery) (res abci.ResponseQuery) {