feat: handle pull_request_review events

gnolang · Dec 8, 2024 · 4f7b0b8 · 4f7b0b8
1 parent f491d95
commit 4f7b0b8
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 2 deletions.
diff --git a/.github/workflows/bot.yml b/.github/workflows/bot.yml
@@ -14,6 +14,10 @@ on:
       - converted_to_draft
       - ready_for_review
 
+  # Watch for changes on PR reviews
+  pull_request_review:
+    types: [submitted, edited, dismissed]
+
   # Watch for changes on PR comment
   issue_comment:
     types: [created, edited, deleted]

diff --git a/contribs/github-bot/internal/matrix/matrix.go b/contribs/github-bot/internal/matrix/matrix.go
@@ -113,7 +113,7 @@ func getPRListFromEvent(gh *client.GitHub, actionCtx *githubactions.GitHubContex
 
 	// Event triggered by an issue / PR comment being created / edited / deleted
 	// or any update on a PR.
-	case utils.EventIssueComment, utils.EventPullRequest, utils.EventPullRequestTarget:
+	case utils.EventIssueComment, utils.EventPullRequest, utils.EventPullRequestReview, utils.EventPullRequestTarget:
 		// For these events, retrieve the number of the associated PR from the context.
 		prNum, err := utils.GetPRNumFromActionsCtx(actionCtx)
 		if err != nil {

diff --git a/contribs/github-bot/internal/matrix/matrix_test.go b/contribs/github-bot/internal/matrix/matrix_test.go
@@ -54,6 +54,15 @@ func TestProcessEvent(t *testing.T) {
 			prs,
 			utils.PRList{1},
 			false,
+		}, {
+			"valid pull_request_review event",
+			&githubactions.GitHubContext{
+				EventName: utils.EventPullRequestReview,
+				Event:     map[string]any{"pull_request": map[string]any{"number": 1.}},
+			},
+			prs,
+			utils.PRList{1},
+			false,
 		}, {
 			"valid pull_request_target event",
 			&githubactions.GitHubContext{

diff --git a/contribs/github-bot/internal/utils/actions.go b/contribs/github-bot/internal/utils/actions.go
@@ -30,7 +30,7 @@ func GetPRNumFromActionsCtx(actionCtx *githubactions.GitHubContext) (int, error)
 	switch actionCtx.EventName {
 	case EventIssueComment:
 		firstKey = "issue"
-	case EventPullRequest, EventPullRequestTarget:
+	case EventPullRequest, EventPullRequestReview, EventPullRequestTarget:
 		firstKey = "pull_request"
 	default:
 		return 0, fmt.Errorf("unsupported event: %s", actionCtx.EventName)

diff --git a/contribs/github-bot/internal/utils/github_const.go b/contribs/github-bot/internal/utils/github_const.go
@@ -5,6 +5,7 @@ const (
 	// GitHub Actions Event Names.
 	EventIssueComment      = "issue_comment"
 	EventPullRequest       = "pull_request"
+	EventPullRequestReview = "pull_request_review"
 	EventPullRequestTarget = "pull_request_target"
 	EventWorkflowDispatch  = "workflow_dispatch"