Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feedback form #16

Merged
merged 11 commits into from
Apr 23, 2024
Merged

feat: feedback form #16

merged 11 commits into from
Apr 23, 2024

Conversation

alexiscolin
Copy link
Member

related to gnolang/gno#1505, this PR aims to add a feedback form to the Gno Doc

@alexiscolin alexiscolin self-assigned this Apr 8, 2024
@alexiscolin alexiscolin marked this pull request as draft April 8, 2024 13:36
Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for gno-docs ready!

Name Link
🔨 Latest commit 0502ec0
🔍 Latest deploy log https://app.netlify.com/sites/gno-docs/deploys/6627a00c3cd76200083cc4db
😎 Deploy Preview https://deploy-preview-16--gno-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 88
Accessibility: 95
Best Practices: 100
SEO: 90
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@alexiscolin alexiscolin requested a review from leohhhn April 8, 2024 13:44
@alexiscolin alexiscolin changed the title Feat/feedback form feat: feedback form Apr 8, 2024
@leohhhn
Copy link
Contributor

leohhhn commented Apr 10, 2024

@alexiscolin thanks for this.
I have a couple of points in mind regarding this:

  • Where do we want to redirect the user when they submit feedback? Maybe, we should make the feedback form into a "Thanks for feedback" (basically not redirect them anywhere)
  • It would be great if its possible to include in the feedback data, the index/ID/URL, maybe even commit, of the page they left the feedback on. This way we know exactly what version of which page they left the feedback on
  • Small typo: Give a feedback > Leave feedback
  • Was this documentation helpful? > Was this page helpful?
  • I will ask Ops where to store the feedback data.

@alexiscolin
Copy link
Member Author

@leohhhn I've linked the form to the form ;)

@alexiscolin alexiscolin marked this pull request as ready for review April 22, 2024 22:42
Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Would be great to get some more validation in the fields - email and feedback fields cannot not be empty when the user sends feedback.

Also, I see that the Page ID in the Google Sheet is not relayed yet, it only says "/" for every feedback that is sent.

About the page commit, it's a nice to have, so lets see if it's too complicated to implement or not.

@alexiscolin
Copy link
Member Author

@leohhhn I've added the page commit from Github API and set the fields as required to ensure all of them are filled before shipping the content. Regarding the page url, that's weird, if you look at the result in gform, you will see that it looks ok with mine. Is it still the case for you?

Co-authored-by: Leon Hudak <[email protected]>
Signed-off-by: Alexis Colin <[email protected]>
Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Co-authored-by: Leon Hudak <[email protected]>
Signed-off-by: Alexis Colin <[email protected]>
@alexiscolin alexiscolin merged commit 62a90c8 into main Apr 23, 2024
5 checks passed
@alexiscolin alexiscolin deleted the feat/feedback-form branch April 23, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants