-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: feedback form #16
Conversation
✅ Deploy Preview for gno-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@alexiscolin thanks for this.
|
@leohhhn I've linked the form to the form ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Would be great to get some more validation in the fields - email and feedback fields cannot not be empty when the user sends feedback.
Also, I see that the Page ID in the Google Sheet is not relayed yet, it only says "/" for every feedback that is sent.
About the page commit, it's a nice to have, so lets see if it's too complicated to implement or not.
@leohhhn I've added the page commit from Github API and set the fields as |
Co-authored-by: Leon Hudak <[email protected]> Signed-off-by: Alexis Colin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Co-authored-by: Leon Hudak <[email protected]> Signed-off-by: Alexis Colin <[email protected]>
related to gnolang/gno#1505, this PR aims to add a feedback form to the Gno Doc