Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 2023-10-17_funding-program-q3 #40

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Conversation

waymobetta
Copy link
Contributor

This PR adds blog content + image asset for the Grants & Funding program (so far).

@waymobetta waymobetta marked this pull request as ready for review October 17, 2023 18:19
@waymobetta waymobetta requested a review from leohhhn October 17, 2023 18:34
Copy link
Collaborator

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waymobetta waymobetta self-assigned this Oct 20, 2023

After a great start to the Funding and Grants Program in Q3, below is a breakdown of the percentage of funding allocated to each area of development so far:

![](src/funding.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to use the thumbs.sh script and create a preview with a link to the big one

checkout the first blogpost for example

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waymobetta @leohhhn any update here? I'd love to publish early next week.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leohhhn leohhhn requested a review from a team as a code owner October 30, 2023 15:40
cd $dir
mkdir -p thumbs
for dir in */; do
if [ -d "${dir}src" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [ -d "${dir}src" ]; then

This will create confusion as it silently ignores changes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moul

I'm not sure I am following. This is my understanding of the whole process:

  • Once we have a new post in the pipeline, we run the script to create the thumbnails.
  • Before (i.e. in the first blog post), the original images were located on the same level as README.md, and were automatically/manually(?) uploaded to gnolang.github.io once the PR was merged(?). Do you then also manually update the links within the README.md? This is what I was trying to understand on the call yesterday.

Question:

  • Does adding a /src somehow mess up the automatic uploading of the thumbnails and images to links that actually display correctly?
  • Should we retroactively move all images to their respective /src folders?
  • What did you mean by "silently ignores changes" exactly?

This process should be pretty simple, but I think that we just don't know all of the details & parts that you envisioned so it's taking a bit longer than it should.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check only verifies the existence of the directory and does not determine if there are new images to translate or if the source image has changed. As a result, you must remember to delete the "thumbs" folder whenever you consider it outdated.

This task can be handled by a Makefile or by simply not checking if the directory exists and recreating all the thumbnails.

sips --resampleWidth 600 "$img" --out "thumbs/$img"
done

cd .. # Return to the parent directory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you navigate to */src, you should then navigate back using "cd ../..", not just "..".

I highly recommend using my previous method, which involves using parentheses. It was more readable and reliable.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an error. I changed it to cd ../.. I think it is still readable, since the whole snippet is enclosed with if - fi.

@moul
Copy link
Member

moul commented Nov 6, 2023

i will deploy

you will need to make a new PR to fix the invalid image.

@moul moul merged commit 595d23b into main Nov 6, 2023
2 checks passed
@moul moul deleted the wmb-q3-grants-funding branch November 6, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants