Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background image on wikipedia home is not centered #69

Closed
hrj opened this issue Jan 7, 2015 · 1 comment · Fixed by #80
Closed

Background image on wikipedia home is not centered #69

hrj opened this issue Jan 7, 2015 · 1 comment · Fixed by #80
Assignees
@hrj
Labels
bug css layout rendering
Milestone
0.4

Comments

@hrj
Copy link
Member

hrj commented Jan 7, 2015

Earlier the background image in wikipedia was not visible, but in latest master, the image is visible and is not centred. This might have surfaced after background related changes in jStyleParser.

Need to triage.

Update: confirmed that this is due to jstyleparser update.
@hrj hrj added this to the 0.4 milestone Jan 7, 2015
@hrj
Copy link
Member Author

hrj commented Jan 10, 2015

test-case

@hrj hrj removed the need-triage label Jan 10, 2015
@hrj hrj self-assigned this Jan 10, 2015
hrj added a commit to hrj/gngr that referenced this issue Jan 15, 2015
@hrj
Corrected computation of bg image offset
951a3a2 
Fixes gngrOrg#69
@hrj hrj mentioned this issue Jan 15, 2015
Merged
@hrj hrj closed this as completed in #80 Jan 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hrj hrj

Labels
bug css layout rendering
Projects
None yet
Milestone
0.4
Development

Successfully merging a pull request may close this issue.

Sprint0.4 part A hrj/gngr
1 participant
@hrj