Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show new windows as soon as possible #65

Closed
hrj opened this issue Jan 6, 2015 · 0 comments · Fixed by #80
Closed

Show new windows as soon as possible #65

hrj opened this issue Jan 6, 2015 · 0 comments · Fixed by #80

Comments

@hrj
Copy link
Member

hrj commented Jan 6, 2015

  • When right clicking and opening a URL in new window, the new window is not shown immediately

Need to also check

  • Upon startup
  • Programmatic creation of a window.
@hrj hrj added this to the 0.4 milestone Jan 6, 2015
hrj added a commit to hrj/gngr that referenced this issue Jan 15, 2015
The earlier logic seemed unnecessarily convoluted. It was registering a listener
and only setting the window as a navigator after the progress was completed. This was probably
needed earlier since there used to be a separate progress dialog in lobo.

Resetting it immediately doesn't seem to have any ill effects on the functionality.
However it helps usability immensely, since the window and progress are immediately visible now.

for gngrOrg#65
hrj added a commit to hrj/gngr that referenced this issue Jan 15, 2015
The earlier logic seemed unnecessarily convoluted. It was registering a listener
and only setting the window as a navigator after the progress was completed. This was probably
needed earlier since there used to be a separate progress dialog in lobo.

Resetting it immediately doesn't seem to have any ill effects on the functionality.
However it helps usability immensely, since the window and progress are immediately visible now.

for gngrOrg#65
@hrj hrj mentioned this issue Jan 15, 2015
@hrj hrj closed this as completed in #80 Jan 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant