Fix shulkerboxes.sc 1.21 data components compability #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Senth
changed the title
samule-i
reviewed
Aug 12, 2024
| [item, count, tag] = e~'item'; | ||
| items_left = __add_item_to_vacuum_sboxes(player, item, count, tag, true); | ||
| count_to_remove = count - items_left; | ||
| if (count_to_remove, modify(e, 'nbt_merge', '{Item:{Count:'+(count-count_to_remove)+'b}}')); | ||
| if (count_to_remove, modify(e, 'nbt_merge', '{Item:{count:'+(count-count_to_remove)+'}}')); |
There was a problem hiding this comment.
I just remembered that I need to answer this one. Item should be uppercase. I tried with lowercase first but that did not work. My guess is that {Item: is part of scarpet and not Minecraft, but I'm not too familiar with either one.
|
vacuum didn't work in pickup mode |
|
mb, it work, but only if you have full stack, insted of work even vith one item, like in original |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in data components, the shulker boxes script stopped working in 1.20.5/1.21. This PR makes shulkerboxes.sc compatible with 1.21 (and possibly 1.20.5, but I haven't tested it)
What changed
Countis now lowercasecountBlockEntityTag.Itemsis nowcomponents."minecraft:container"components."minecraft:custom_data"Testing (only tested in 1.21)
Note
I installed the vim plugin for scarpet, which reformatted the file, removing some trailing spaces. I can always split the PR into two if it needs to be more clear.