Tputils: Home and Warps #335
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides CLI for making/deleteing homes and warps. Provides GUI to show all available homes and warps.
Ghoulboy78
reviewed
Aug 13, 2022
programs/survival/tputils.sc
Outdated
| global_hdata:uuid:name:'pitch' = player~'pitch'; | ||
| global_hdata:uuid:name:'yaw' = player~'yaw'; | ||
| global_hdata:uuid:name:'dimension' = player~'dimension'; | ||
| _saveHData(); |
There was a problem hiding this comment.
Same as with another pr u've done I think, I think you should do saveData in __on_close() and that's it to avoid re-writing to disk a bunch of times
Ghoulboy78
reviewed
Aug 13, 2022
Ghoulboy78
reviewed
Aug 13, 2022
programs/survival/tputils.sc
Outdated
Comment on lines
238
to
240
| x= floor(loc:0); | ||
| y= floor(loc:1); | ||
| z= floor(loc:2); |
There was a problem hiding this comment.
This is a completely unrelated point, but this is the same as [x, y, z] = map(loc, floor(_)).
There was a problem hiding this comment.
Oman my whole scarpet life was a lie. I never knew this was possible xD. Imma change it everywhere asap
Co-authored-by: Ghoulboy <[email protected]>
Thanks @Ghoulboy78 for version checking changes and for telling me that `map()` exists
altrisi
reviewed
Oct 16, 2022
|
|
||
| info = global_hdata:str(player()~'uuid'):name; | ||
| if(info==null, | ||
| print(player,format('r \nThe specefied location does not exist. Please use home list to know your current list')); |
There was a problem hiding this comment.
Suggested change
| print(player,format('r \nThe specefied location does not exist. Please use home list to know your current list')); | |
| print(player(),format('r \nThe specefied location does not exist. Please use home list to know your current list')); | |
|
|
||
| _hremove(name) -> ( | ||
| if(global_hdata:str(player()~'uuid'):name==null, | ||
| print(player,format('r \nThe specefied location does not exist. Please use home list to know your current list')); |
There was a problem hiding this comment.
Suggested change
| print(player,format('r \nThe specefied location does not exist. Please use home list to know your current list')); | |
| print(player(),format('r \nThe specefied location does not exist. Please use home list to know your current list')); | |
Comment on lines
+264
to
+279
| _screenCheck() -> ( | ||
| sVersion= split('\\+',system_info('scarpet_version')):0; //fetches first part before the +, eg 1.4.57 | ||
| vNumbers=split('\\.',sVersion); | ||
| [main, sub, x] = map(vNumbers,number(_)); | ||
| if(main>1, | ||
| true, | ||
| main == 1, | ||
| if(sub>4, | ||
| true, | ||
| sub==4, | ||
| x >= 56, | ||
| false | ||
| ), | ||
| false | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Suggestion for if this is false just don't register the subcommand, else a command that does nothing is weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All actions can be performed with CLI (like the waypoints app). Additionally, GUI for actions like displaying/teleporting to available warps. The GUI should only appear if the carpet version > 1.4.56 (I don't remember testing this, but I hope it works) so no need to bump up required version.