-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - load multiple sources #573
base: develop
Are you sure you want to change the base?
Conversation
Hi @valvin1! Thanks for creating this PR. I'd love to merge this, could you make the following changes:
|
@@ -63,6 +63,9 @@ function Slideshow (events, dom, options, callback) { | |||
if (options.sourceUrl) { | |||
loadFromUrl(options.sourceUrl, callback); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor loadFromUrls
and use it here -- (that way we can remove the loadFromUrl
function and only have one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the comments - refactor loadFromUrls + review/add tests if needed to cover the new scenario.
@valvin1 any progress here? this feature is really cool and would like to see it :) |
Hello @peterj I decided to try and help take @valvin1's great idea across the finish line here. I have the work in my fork here. Would it work best to just create a new PR from there? Or should I try and pull it into his original PR branch? Thanks |
As mentionend in #560 this feature allowes to load several sources using option
sourceUrls
instead ofsourceUrl