New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make file reading thread-safe, by having SubFile use read_at/seek_read rather than seek and read. #7

Merged

Tim-Evans-Seequent merged 1 commit into main from 4-file-reads-arent-thread-safe

Jun 25, 2024

Contributor

Tim-Evans-Seequent commented Jun 19, 2024

This fixes the bug of assuming try_clone duplicates the file descriptor, and instead uses an Arc<File> with seeking reads directly.


          Make file reading thread-safe, by having SubFile use read_at/seek_rea…

f67715e

…d rather than seek and read.

Tim-Evans-Seequent linked an issue

that may be closed by this pull request

File reads aren't thread safe #4

Closed

Tim-Evans-Seequent merged commit 517af83 into main

5 checks passed

Tim-Evans-Seequent deleted the 4-file-reads-arent-thread-safe branch

June 25, 2024 22:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet