Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show grey song #211

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Show grey song #211

merged 2 commits into from
Nov 24, 2022

Conversation

catsout
Copy link
Contributor

@catsout catsout commented Nov 24, 2022

@gmg137
Copy link
Owner

gmg137 commented Nov 24, 2022

在搜索歌曲页面没有对灰色歌曲做处理,请修正后合并提交。

@catsout
Copy link
Contributor Author

catsout commented Nov 24, 2022

不影响播放
搜索好像需要改用其他接口,之后再处理吧。
之后还想给搜索结果加个 end 判断。

@catsout catsout changed the title Show grey song Show grey song in album/playlist Nov 24, 2022
@catsout
Copy link
Contributor Author

catsout commented Nov 24, 2022

@gmg137
Copy link
Owner

gmg137 commented Nov 24, 2022

在查看歌手页面也没有做灰色歌曲处理,你看下是否可以加上。

@catsout
Copy link
Contributor Author

catsout commented Nov 24, 2022

不用,gui/songlist_view.rs 已经处理了,查看歌手页面用的也是 songlist_view.
只是 api 那边都还没处理,都是 unknown.

@catsout catsout changed the title Show grey song in album/playlist Show grey song Nov 24, 2022
@catsout
Copy link
Contributor Author

catsout commented Nov 24, 2022

api 那处理后,搜索页面和查看歌手页面应该都能正常显示灰色歌曲.

@gmg137 gmg137 merged commit b7523d6 into gmg137:master Nov 24, 2022
@OnePieceJoker
Copy link

打扰下,目前通过paru下载aur,依赖的ncm-api版本不对了,调整了SongListDetailDynamic等结构,现在编译不过,新版本准备什么时候更新到aur那边

@OnePieceJoker
Copy link

cargo这边在拉取netease-cloud-music-api 1.1.1的时候,锁到最新的commit了,我去看下怎么回事。打扰了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants