Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poc add failure store #8

Closed
wants to merge 24 commits into from

Conversation

gmarouli
Copy link
Owner

This PR is a draft alternative of elastic#103518 given that this refactoring is accepted.

We believe that this refactoring, makes the option to add the failure store to the current IndicesOptions a possibility.

  • The new builders allow us to (temporarily) rebuild IndicesOptions with the failure store without having to extend the boolean factory methods.
  • Using the builders means that the default option of not including the failure store indices is applied everywhere.
  • It will make adding this to search easier because there are a lot of request rewrites that we need to wire the DataStreamOptions while like this we can rely on the existing infrastructure.

I am starting to see potential here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant