Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.2 compatibility, revert imap monkey patch #283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ rvm:
- 2.0.0
- 2.1.5
- 2.2.0
- 3.2.0
- rbx
- jruby

Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Gmail Gem Changelog

## 0.7.2 - 2023-01-25

* Fix issue related to Ruby 3.2 - String#untaint was deprecated

## 0.7.1 - 2018-07-19

* Fix issue related to Net::IMAP.format_date change (@mnohai-mdsol)
Expand Down
1 change: 0 additions & 1 deletion lib/gmail/client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ def self.new(name, *args)
raise UnknownClient, "No such client: #{name}"
end

require 'gmail/imap_extensions'
require 'gmail/client/base'
require 'gmail/client/plain'
require 'gmail/client/xoauth'
Expand Down
1 change: 0 additions & 1 deletion lib/gmail/client/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ def initialize(username, options = {})
# Connect to gmail service.
def connect(raise_errors = false)
@imap = Net::IMAP.new(GMAIL_IMAP_HOST, GMAIL_IMAP_PORT, true, nil, false)
Gmail::ImapExtensions.patch_net_imap_response_parser
@imap
rescue SocketError
raise_errors and raise ConnectionError, "Couldn't establish connection with Gmail IMAP service"
Expand Down
2 changes: 1 addition & 1 deletion lib/gmail/imap_extensions.rb
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def x_gm_label_list
if flag.empty?
x
else
flag.first.first.capitalize.untaint.intern
flag.first.first.capitalize.intern
end
end
else
Expand Down
2 changes: 1 addition & 1 deletion lib/gmail/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Gmail
VERSION = "0.7.1".freeze
VERSION = "0.7.2".freeze
end