Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add vibrancy and configuration options #133

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

veryard
Copy link
Contributor

@veryard veryard commented Oct 27, 2024

This closes the following: #93

Notes:

  1. Color isn't widely supported, only Windows 10 v1903+, no effect on Windows 7 or Windows 11 (https://docs.rs/tauri-utils/latest/x86_64-apple-darwin/tauri_utils/config/struct.WindowEffectsConfig.html#structfield.color)
  2. Blur: bad performance when resizing - Should be fine considering zebar should pin to top (https://github.com/tauri-apps/window-vibrancy?tab=readme-ov-file#available-functions)
  3. Acrylic: bad performance when resizing - Should be fine considering zebar should pin to top (https://github.com/tauri-apps/window-vibrancy?tab=readme-ov-file#available-functions)

Testing:

  • MacOS: I do not have a Macbook so I left it out for now.
  • Windows 10: Will boot up a VM this coming week to verify, unless someone can give it a crack for me.

New configuration options:

  • backgroundEffect: None, Blur, Acrylic, Mica, Vibrancy (Made optional)
  • backgroundEffectColor: String, hex, rgb etc etc (Made optional)
  • background_effect_mica_dark Bool (Made optional defaults to false)

Happy to hold of this until the vibrancy package has improved to work on newer versions of Windows, and please let me know if any issues with code, not use to writing Rust so I apologize!

@veryard
Copy link
Contributor Author

veryard commented Nov 1, 2024

Todo:

  • since acrylic, mica, and macos vibrancy can potentially all take various config options, it'd make sense to have separate effects depending on os
  • Settings UI to have nice ui like attached
    image
    image

packages/desktop/src/config.rs Show resolved Hide resolved
packages/desktop/Cargo.toml Outdated Show resolved Hide resolved
packages/desktop/Cargo.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📬 Needs triage
Development

Successfully merging this pull request may close these issues.

2 participants