Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression in layouting with fullscreen state and various taskbar alignments #823

Closed
wants to merge 4 commits into from

Conversation

Dovias
Copy link

@Dovias Dovias commented Nov 3, 2024

This PR implements fixes for #790 and #640 issues

I've tested StartAllBack and Windhawk's top taskbar mod by @m417z , but I am pretty confident ExplorerPatcher would also work due to the nature of StartAllBack's use of classic taskbar.

Note: I've learned Rust basics just because how annoying this bug was for me, so if you see some spots which look kind of bad in the code, please review it 🤣

Implementation note: This PR completely removes Rect's apply_delta() and apply_inverse_delta() functions as they were suited only for Window calculations, completely ignoring Workspace delta requirements. All of the calculations required to fix this in this PR were made in-place by constructing a Rect viaRect::from_ltrb() function instead.

Before (this issue persists since at least GlazeWM 3.4.0):

1X4bR9HXlZ.mp4
NiJVQYdLDU.mp4

After:

nhiHirkUFy.mp4
aYcx5kmde3.mp4

@BlenderEngineer
Copy link

Very cool. Good job

@Dovias
Copy link
Author

Dovias commented Nov 4, 2024

Added a fix for fullscreen overflow under taskbar (this issue persists even with a bottom taskbar on GlazeWM 3.5.0)

Before

WCdfiBtDt3.mp4

After:

brave_j6X1wQc2UA.mp4

@Dovias
Copy link
Author

Dovias commented Nov 6, 2024

Added a fix for automatic minimization for fullscreen windows if the non-floating window is being used

Before:

explorer_YbmtR3Bwsv.mp4

After:

brave_KMfguVRyt3.mp4

@Dovias Dovias changed the title fix: regression in layouting with taskbar alignments fix: regression in layouting with fullscreen state and various taskbar alignments Nov 6, 2024
@Dovias
Copy link
Author

Dovias commented Nov 7, 2024

After discussing this with core team, we've decided that this PR is too big to be merged. This PR will be separated into three separate PR's which will represent according fixes separately.

@Dovias Dovias closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants