fix: regression in layouting with fullscreen state and various taskbar alignments #823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements fixes for #790 and #640 issues
I've tested StartAllBack and Windhawk's top taskbar mod by @m417z , but I am pretty confident ExplorerPatcher would also work due to the nature of StartAllBack's use of classic taskbar.
Note: I've learned Rust basics just because how annoying this bug was for me, so if you see some spots which look kind of bad in the code, please review it 🤣
Implementation note: This PR completely removes
Rect
'sapply_delta()
andapply_inverse_delta()
functions as they were suited only forWindow
calculations, completely ignoringWorkspace
delta requirements. All of the calculations required to fix this in this PR were made in-place by constructing aRect
viaRect::from_ltrb()
function instead.Before (this issue persists since at least GlazeWM 3.4.0):
1X4bR9HXlZ.mp4
NiJVQYdLDU.mp4
After:
nhiHirkUFy.mp4
aYcx5kmde3.mp4