This repository has been archived by the owner on Jul 17, 2023. It is now read-only.
GUAC-1172: Upgrade to Angular 1.3 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itization strategy. Use null instead of false for lack of login error.
…ng the translate directive (no filter). Current scope is not available to filters as of AngularJS 1.3.
jmuehlner
added a commit
that referenced
this pull request
Jul 3, 2015
GUAC-1172: Upgrade to Angular 1.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates to Angular 1.3.16 - the latest stable version. This also requires updating to the latest angular-translate (2.7.2). Simply updating these two libraries works well, but resulted in two problems that required workarounds:
ngRepeatis used on the root of a directive usingreplace: true(Parent scope not inherited within directive using ngRepeat and replace angular/angular.js#12260). I've worked around this by ensuring no directives usengRepeaton their root.messageformatinterpolation within angular-translate (messageformat interpolation: variables handling fails with angular 1.3+ angular-translate/angular-translate#788). I've worked around this by using thetranslatedirective (not the filter) wherevermessageformatinterpolation is used.