Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-617: Fix: requireEnoughFunds was being passed a seed in some commands #1235

Closed
wants to merge 1 commit into from

Conversation

pLabarta
Copy link
Contributor

@pLabarta pLabarta commented Aug 4, 2023

Description of proposed changes

This was causing some commands to fail when checking for funds in distribute-rewards, set-keys and unbond. Was found when working on the CLI integration tests.


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #1235 (71ef444) into dev (e06ceba) will increase coverage by 60.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             dev    #1235       +/-   ##
==========================================
+ Coverage   9.34%   69.36%   +60.02%     
==========================================
  Files         26      101       +75     
  Lines        792    11901    +11109     
  Branches      97       97               
==========================================
+ Hits          74     8255     +8181     
- Misses       718     3646     +2928     
Files Changed Coverage Δ
scripts/cc-cli/src/commands/distributeRewards.ts 0.00% <0.00%> (ø)
scripts/cc-cli/src/commands/setKeys.ts 0.00% <0.00%> (ø)
scripts/cc-cli/src/commands/unbond.ts 0.00% <0.00%> (ø)

... and 75 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

For full LLVM coverage report click here!

@atodorov atodorov changed the title Fix: requireEnoughFunds was being passed a seed in some commands CSUB-617: Fix: requireEnoughFunds was being passed a seed in some commands Aug 9, 2023
Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can now execute distribute-rewards without the cli crashing.

@atodorov
Copy link
Contributor

Merged as part of #1230

@atodorov atodorov closed this Aug 10, 2023
@atodorov atodorov deleted the fix-require-enough-funds branch August 10, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants