Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSUB-673] Increase max authorities #1231

Merged
merged 3 commits into from
Aug 1, 2023
Merged

[CSUB-673] Increase max authorities #1231

merged 3 commits into from
Aug 1, 2023

Conversation

nathanwhit
Copy link
Contributor

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Merging #1231 (ae3591f) into dev (8085dd6) will not change coverage.
The diff coverage is n/a.

❗ Current head ae3591f differs from pull request most recent head 2970799. Consider uploading reports for the commit 2970799 to get more accurate results

@@           Coverage Diff           @@
##              dev    #1231   +/-   ##
=======================================
  Coverage   69.50%   69.50%           
=======================================
  Files         100      100           
  Lines       11877    11877           
  Branches       89       89           
=======================================
  Hits         8255     8255           
  Misses       3622     3622           
Files Changed Coverage Δ
runtime/src/lib.rs 15.69% <ø> (ø)
runtime/src/version.rs 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

For full LLVM coverage report click here!

@pLabarta pLabarta merged commit 8048924 into dev Aug 1, 2023
@pLabarta pLabarta deleted the increase-max-authorities branch August 1, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants