Misc PoS cleanup and improvements #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
force-pushed
the
misc-pos-cleanup-and-improvements
branch
from
770ffa7
to
b5af617
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1207 +/- ##
==========================================
- Coverage 69.36% 69.24% -0.13%
==========================================
Files 101 101
Lines 11901 11922 +21
Branches 97 97
==========================================
Hits 8255 8255
- Misses 3646 3667 +21
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
For full LLVM coverage report click here! |
atodorov
previously approved these changes
Jul 28, 2023
nathanwhit
force-pushed
the
misc-pos-cleanup-and-improvements
branch
from
20050e4
to
038e2fc
Compare
nathanwhit
force-pushed
the
misc-pos-cleanup-and-improvements
branch
from
65e9079
to
e105b28
Compare
atodorov
approved these changes
Aug 9, 2023
zacharyfrederick
approved these changes
Aug 9, 2023
AdaJane
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Add grandpa RPCs * Enable warp sync * Add BadBlocks to chain spec extensions * Add PoS devnet chainspec * Remove commented out line * Appease version check * Add grandpa RPC sanity integration test * Auto-update creditcoin-js type definitions * Make grandpa test a little bit more substantive * Appease clippy --------- Co-authored-by: gluwa-bot <[email protected]>
AdaJane
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Add grandpa RPCs * Enable warp sync * Add BadBlocks to chain spec extensions * Add PoS devnet chainspec * Remove commented out line * Appease version check * Add grandpa RPC sanity integration test * Auto-update creditcoin-js type definitions * Make grandpa test a little bit more substantive * Appease clippy --------- Co-authored-by: gluwa-bot <[email protected]>
AdaJane
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Add grandpa RPCs * Enable warp sync * Add BadBlocks to chain spec extensions * Add PoS devnet chainspec * Remove commented out line * Appease version check * Add grandpa RPC sanity integration test * Auto-update creditcoin-js type definitions * Make grandpa test a little bit more substantive * Appease clippy --------- Co-authored-by: gluwa-bot <[email protected]>
atodorov
pushed a commit
that referenced
this pull request
Aug 15, 2023
* Add grandpa RPCs * Enable warp sync * Add BadBlocks to chain spec extensions * Add PoS devnet chainspec * Remove commented out line * Appease version check * Add grandpa RPC sanity integration test * Auto-update creditcoin-js type definitions * Make grandpa test a little bit more substantive * Appease clippy --------- Co-authored-by: gluwa-bot <[email protected]>
zacharyfrederick
pushed a commit
that referenced
this pull request
Aug 16, 2023
* Add grandpa RPCs * Enable warp sync * Add BadBlocks to chain spec extensions * Add PoS devnet chainspec * Remove commented out line * Appease version check * Add grandpa RPC sanity integration test * Auto-update creditcoin-js type definitions * Make grandpa test a little bit more substantive * Appease clippy --------- Co-authored-by: gluwa-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This is sort of a mishmash of changes, but there are two general categories here:
Things that make disaster recovery easier (found during research for CSUB-260)
BadBlockschain spec extension (this allows you to blacklist certain block hashes to easily hard fork)Things that I should have done
I can split it into multiple PRs, but I wanted to get something up before I forgot about this
Practical tips for PR review & merge:
Commit by commit