Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-463: Load testing for npos #1206

Merged
merged 10 commits into from
Aug 14, 2023
Merged

Conversation

atodorov
Copy link
Contributor

Description of proposed changes

Still trying out things


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Merging #1206 (f91f16b) into dev (198e6d0) will decrease coverage by 61.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev   #1206       +/-   ##
==========================================
- Coverage   69.69%   8.20%   -61.50%     
==========================================
  Files         103      28       -75     
  Lines       12032     902    -11130     
  Branches      112     112               
==========================================
- Hits         8386      74     -8312     
+ Misses       3637     828     -2809     
+ Partials        9       0        -9     

see 83 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

For full LLVM coverage report click here!

@atodorov atodorov force-pushed the testing/CSUB-463-load-testing-for-npos branch 2 times, most recently from 5e2bf2a to 009168c Compare August 2, 2023 07:35
@atodorov atodorov force-pushed the testing/CSUB-463-load-testing-for-npos branch 3 times, most recently from 221445f to 724f92a Compare August 9, 2023 08:20
@atodorov atodorov marked this pull request as ready for review August 9, 2023 08:20
@atodorov atodorov force-pushed the testing/CSUB-463-load-testing-for-npos branch from 724f92a to ad6fcfa Compare August 10, 2023 11:49
@atodorov
Copy link
Contributor Author

The failure in https://github.com/gluwa/creditcoin/actions/runs/5820688763/job/15781582765?pr=1206 is caused by an intentional change. The change applies only to fast-runtime and isn't related to production so the failure can be ignored.

because on modern Linux /tmp is ramfs and storing node data there causes
OOM very quickly
otherwise the epoch is too short and zombienet doesn't have enough time
to launch all 200-300 nodes. As a result 1/3-1/2 of the validators get
slashed immediately b/c they don't have time to send their i-am-online
pings
as a reminder of how to speed-up the initial lauch phase of all nodes
when using a single test machine
@atodorov atodorov force-pushed the testing/CSUB-463-load-testing-for-npos branch from ad6fcfa to f91f16b Compare August 11, 2023 14:38
@AdaJane AdaJane merged commit 73e779f into dev Aug 14, 2023
@AdaJane AdaJane deleted the testing/CSUB-463-load-testing-for-npos branch August 14, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants