Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-619: Add more tests for register_address_v2 #1202

Merged
merged 5 commits into from
Jul 21, 2023
Merged

CSUB-619: Add more tests for register_address_v2 #1202

merged 5 commits into from
Jul 21, 2023

Conversation

zacharyfrederick
Copy link
Contributor

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Merging #1202 (daeb5b9) into dev (4beef4e) will decrease coverage by 0.07%.
The diff coverage is 61.85%.

@@            Coverage Diff             @@
##              dev    #1202      +/-   ##
==========================================
- Coverage   69.57%   69.50%   -0.07%     
==========================================
  Files         100      100              
  Lines       11791    11877      +86     
  Branches       89       89              
==========================================
+ Hits         8203     8255      +52     
- Misses       3588     3622      +34     
Impacted Files Coverage Δ
pallets/creditcoin/src/tests.rs 98.16% <57.83%> (-1.69%) ⬇️
pallets/creditcoin/src/helpers.rs 83.18% <75.00%> (-0.93%) ⬇️
pallets/creditcoin/src/lib.rs 83.69% <100.00%> (+0.23%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

For full LLVM coverage report click here!

@atodorov atodorov changed the title addressed previous QA issues brought up by Alex CSUB-619: Add more tests for register_address_v2 Jul 17, 2023
pallets/creditcoin/src/helpers.rs Outdated Show resolved Hide resolved
pallets/creditcoin/src/tests.rs Outdated Show resolved Hide resolved
pallets/creditcoin/src/tests.rs Show resolved Hide resolved
pallets/creditcoin/src/tests.rs Outdated Show resolved Hide resolved
pallets/creditcoin/src/tests.rs Show resolved Hide resolved
pallets/creditcoin/src/tests.rs Outdated Show resolved Hide resolved
pallets/creditcoin/src/tests.rs Outdated Show resolved Hide resolved
pallets/creditcoin/src/tests.rs Show resolved Hide resolved
Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes requested.

pallets/creditcoin/src/helpers.rs Outdated Show resolved Hide resolved
pallets/creditcoin/src/tests.rs Show resolved Hide resolved
pallets/creditcoin/src/helpers.rs Outdated Show resolved Hide resolved
atodorov
atodorov previously approved these changes Jul 19, 2023
atodorov
atodorov previously approved these changes Jul 19, 2023
atodorov
atodorov previously approved these changes Jul 21, 2023
atodorov
atodorov previously approved these changes Jul 21, 2023
@atodorov atodorov merged commit 458247c into dev Jul 21, 2023
@atodorov atodorov deleted the csub-619-qa branch July 21, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants