Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-630: Add missing error handling to wizard, bond & validate #1195

Merged
merged 6 commits into from
Jul 19, 2023

Conversation

pLabarta
Copy link
Contributor

@pLabarta pLabarta commented Jul 7, 2023

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2023

Codecov Report

Merging #1195 (ee2a70a) into dev (f4d0188) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##              dev    #1195   +/-   ##
=======================================
  Coverage   69.65%   69.65%           
=======================================
  Files         100      100           
  Lines       11743    11743           
  Branches       83       83           
=======================================
  Hits         8180     8180           
  Misses       3563     3563           
Impacted Files Coverage Δ
scripts/cc-cli/src/commands/balance.ts 0.00% <0.00%> (ø)
scripts/cc-cli/src/commands/bond.ts 0.00% <0.00%> (ø)
scripts/cc-cli/src/commands/distributeRewards.ts 0.00% <0.00%> (ø)
scripts/cc-cli/src/commands/send.ts 0.00% <0.00%> (ø)
scripts/cc-cli/src/commands/status.ts 0.00% <0.00%> (ø)
scripts/cc-cli/src/commands/validate.ts 0.00% <0.00%> (ø)
scripts/cc-cli/src/commands/wizard.ts 0.00% <0.00%> (ø)
scripts/cc-cli/src/utils/parsing.ts 77.27% <91.66%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

For full LLVM coverage report click here!

atodorov
atodorov previously approved these changes Jul 11, 2023
Copy link
Contributor

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo but otherwise LGTM

scripts/cc-cli/src/utils/parsing.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what's going on here https://github.com/gluwa/creditcoin/actions/runs/5554833335/jobs/10145533752.

All test scenarios seem to report PASS but the command is still exiting with a 1 causing the CI job to fail.

We can investigate after the other PRs are merged and this one has been rebased.

atodorov
atodorov previously approved these changes Jul 14, 2023
nathanwhit
nathanwhit previously approved these changes Jul 14, 2023
@pLabarta pLabarta dismissed stale reviews from nathanwhit and atodorov via 31691c2 July 14, 2023 20:56
@pLabarta pLabarta force-pushed the cli-validate-commission branch 2 times, most recently from 31691c2 to bd3a6ab Compare July 19, 2023 13:29
@atodorov atodorov merged commit 4beef4e into dev Jul 19, 2023
31 of 34 checks passed
@atodorov atodorov deleted the cli-validate-commission branch July 19, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants