-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSUB-630: Add missing error handling to wizard, bond & validate #1195
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1195 +/- ##
=======================================
Coverage 69.65% 69.65%
=======================================
Files 100 100
Lines 11743 11743
Branches 83 83
=======================================
Hits 8180 8180
Misses 3563 3563
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
For full LLVM coverage report click here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo but otherwise LGTM
a448e47
to
45f2a3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what's going on here https://github.com/gluwa/creditcoin/actions/runs/5554833335/jobs/10145533752.
All test scenarios seem to report PASS but the command is still exiting with a 1 causing the CI job to fail.
We can investigate after the other PRs are merged and this one has been rebased.
31691c2
to
bd3a6ab
Compare
Co-authored-by: Nathan Whitaker <[email protected]>
bd3a6ab
to
ebcd4d7
Compare
Description of proposed changes
Practical tips for PR review & merge: