Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol/client: Initialize list head to prevent NULL de-reference #2457

Merged
merged 1 commit into from
May 27, 2021

Conversation

pranithk
Copy link
Member

fixes: #2443
Change-Id: I86ef0270d41d6fb924db97fde3196d7c98c8b564
Signed-off-by: Pranith Kumar K [email protected]

@pranithk
Copy link
Member Author

/run regression

amarts
amarts previously approved these changes May 20, 2021
@mykaul
Copy link
Contributor

mykaul commented May 20, 2021

In

__destroy_client_lock(lock);
we __destroy_client_lock() without first calling __delete_client_lock() - is that OK?

@pranithk
Copy link
Member Author

In

__destroy_client_lock(lock);

we __destroy_client_lock() without first calling __delete_client_lock() - is that OK?

yeah, lock is a single element, not part of any other list.

@pranithk pranithk added the release 9 release 9 label May 20, 2021
fixes: gluster#2443
Change-Id: I86ef0270d41d6fb924db97fde3196d7c98c8b564
Signed-off-by: Pranith Kumar K <[email protected]>
@pranithk
Copy link
Member Author

/run regression

@pranithk pranithk requested a review from xhernandez May 25, 2021 11:26
@xhernandez xhernandez merged commit 2f01eb5 into gluster:release-9 May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release 9 release 9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants