Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update admin_distributed_geo_rep.md #20

Closed
wants to merge 1 commit into from
Closed

Update admin_distributed_geo_rep.md #20

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 7, 2014

changed the first few sections of the readme. just some changes to grammar and spelling.

changed the first few sections of the readme. just some changes to grammar and spelling.
@justinclift
Copy link
Contributor

Cool, this looks like good tweaking. 😄

Would you be ok with submitting this PR to Gerrit, where we do our patch review work?

    http://review.gluster.org

GitHub is just a mirror for us, and unfortunately there's no good way to disable pull requests here so we can point people to the right place (has been suggested to GH staff, but no luck 😦).

If you don't have the time/inclination to do that, just let me know and I'll get it done instead. 😄

@ghost
Copy link
Author

ghost commented Aug 12, 2014

i can take care of it, but i will have to look into the code review
then i can add some bits to the md file. sound ok?

On 11 August 2014 19:21, Justin Clift [email protected] wrote:

Cool, this looks like good tweaking. [image: 😄]

Would you be ok with submitting this PR to Gerrit, where we do our patch
review work?

http://review.gluster.org

GitHub is just a mirror for us, and unfortunately there's no good way to
disable pull requests here so we can point people to the right place (has
been suggested to GH staff, but no luck [image: 😦]).

If you don't have the time/inclination to do that, just let me know and
I'll get it done instead. [image: 😄]


Reply to this email directly or view it on GitHub
#20 (comment).

@justinclift
Copy link
Contributor

Yep, that works. 😄

@ghost
Copy link
Author

ghost commented Aug 12, 2014

having trouble finding it, any help?
admin_distributed_geo_rep.md

On 12 August 2014 17:37, Justin Clift [email protected] wrote:

Yep, that works. [image: 😄]


Reply to this email directly or view it on GitHub
#20 (comment).

@justinclift
Copy link
Contributor

Heh, I'm a bit confused. What're you having trouble finding?

The admin_distributed_geo_rep.md file should be under doc/admin-guide/en-US/markdown/ if that helps?

@ghost
Copy link
Author

ghost commented Aug 12, 2014

i have been trying 'file:' searches with no results, regex seems to not
work "operator not permitted"
sorry but, can you give me some idea how to search and find this file?
i have never used gerrit before, i am a little lost

On 12 August 2014 17:49, Justin Clift [email protected] wrote:

Heh, I'm a bit confused. What're you having trouble finding?

The admin_distributed_geo_rep.md file should be under
doc/admin-guide/en-US/markdown/ if that helps?


Reply to this email directly or view it on GitHub
#20 (comment).

@justinclift
Copy link
Contributor

Ahhh gotcha. Yeah, Gluster was my first experience of Gerrit as well. It was a bit of a learning experience for me too, but worth the effort. 😄

Some of the guys have written up intro type instructions here, specifically for how the Gluster Community does stuff:

    http://gluster.org/community/documentation/index.php/Simplified_dev_workflow

Do they help?

@justinclift
Copy link
Contributor

@natemccoy How'd you go with this? 😄

@justinclift
Copy link
Contributor

@natemccoy Looks like this didn't get to Gerrit. Is it ok if I submit the patch there, or do you want me to walk you through the Gerrit setup process so you can do it or ? 😄

@ghost
Copy link
Author

ghost commented Oct 6, 2014

I would like to do it but have been busy as of late

I think it is a skill I.should acquire.

Is there a way I can write you directly when I am ready to submit?
On 5 Oct 2014 19:20, "Justin Clift" [email protected] wrote:

@natemccoy https://github.com/natemccoy Looks like this didn't get to
Gerrit. Is it ok if I submit the patch there, or do you want me to walk you
through the Gerrit setup process so you can do it or ? [image: 😄]


Reply to this email directly or view it on GitHub
#20 (comment).

@justinclift
Copy link
Contributor

Sure. Email me directly at [email protected] (whenever you're ready) and we'll figure it out from there. Happy to walk you through the steps to get you up and running. 😄

@amarts
Copy link
Member

amarts commented Nov 5, 2019

GlusterFS used Gerrit Workflow to review and merge patches, and hence PRs here got left out. Sorry about that.

A lot has changed in 5 yrs, and this portion of the codebase is moved to glusterdocs repo. Hence closing the PR.

Thanks for the interest :-)

@amarts amarts closed this Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants