-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update admin_distributed_geo_rep.md #20
Conversation
changed the first few sections of the readme. just some changes to grammar and spelling.
Cool, this looks like good tweaking. 😄 Would you be ok with submitting this PR to Gerrit, where we do our patch review work? GitHub is just a mirror for us, and unfortunately there's no good way to disable pull requests here so we can point people to the right place (has been suggested to GH staff, but no luck 😦). If you don't have the time/inclination to do that, just let me know and I'll get it done instead. 😄 |
i can take care of it, but i will have to look into the code review On 11 August 2014 19:21, Justin Clift [email protected] wrote:
|
Yep, that works. 😄 |
having trouble finding it, any help? On 12 August 2014 17:37, Justin Clift [email protected] wrote:
|
Heh, I'm a bit confused. What're you having trouble finding? The admin_distributed_geo_rep.md file should be under doc/admin-guide/en-US/markdown/ if that helps? |
i have been trying 'file:' searches with no results, regex seems to not On 12 August 2014 17:49, Justin Clift [email protected] wrote:
|
Ahhh gotcha. Yeah, Gluster was my first experience of Gerrit as well. It was a bit of a learning experience for me too, but worth the effort. 😄 Some of the guys have written up intro type instructions here, specifically for how the Gluster Community does stuff: http://gluster.org/community/documentation/index.php/Simplified_dev_workflow Do they help? |
@natemccoy How'd you go with this? 😄 |
@natemccoy Looks like this didn't get to Gerrit. Is it ok if I submit the patch there, or do you want me to walk you through the Gerrit setup process so you can do it or ? 😄 |
I would like to do it but have been busy as of late I think it is a skill I.should acquire. Is there a way I can write you directly when I am ready to submit?
|
Sure. Email me directly at [email protected] (whenever you're ready) and we'll figure it out from there. Happy to walk you through the steps to get you up and running. 😄 |
GlusterFS used Gerrit Workflow to review and merge patches, and hence PRs here got left out. Sorry about that. A lot has changed in 5 yrs, and this portion of the codebase is moved to glusterdocs repo. Hence closing the PR. Thanks for the interest :-) |
changed the first few sections of the readme. just some changes to grammar and spelling.