Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE for glusterfind (Bugzilla Bug 1392347) #579

Closed
vbellur opened this issue Nov 19, 2018 · 3 comments
Closed

RFE for glusterfind (Bugzilla Bug 1392347) #579

vbellur opened this issue Nov 19, 2018 · 3 comments
Labels
DocApproved Mandatory flag to pass smoke. Provide user facing document to get approval. SpecApproved This is a mandatory flag for passing the smoke for feature. Provide spec of feature to get approval
Milestone

Comments

@vbellur
Copy link
Member

vbellur commented Nov 19, 2018

This issue was created automatically with bugzilla2github

Bugzilla Bug 1392347

Date: 2016-11-07 04:47:00 -0500
From: Milind Changire <>
To: Milind Changire <>
CC: amukherj, avishwan, bugs, ccalhoun, khiremat, rhs-bugs, storage-qa-internal

Blocker for: #1383723
Last updated: 2018-02-06 17:34:38 -0500

Comment 9865925

Date: 2016-11-07 04:50:03 -0500
From: Milind Changire <>

Description of problem:

Output of glusterfind includes directories so passing that output to a backup program effectively ignores file lists. Request an output option similar to 'find -type t' to only output filenames.

Comment 9963858

Date: 2016-12-07 04:46:00 -0500
From: Worker Ant <>

REVIEW: http://review.gluster.org/16051 (tools/glusterfind : added --type option) posted (#1) for review on master by Anonymous Coward

Comment 9971412

Date: 2016-12-09 07:43:23 -0500
From: Worker Ant <>

REVIEW: http://review.gluster.org/16051 (tools/glusterfind : added --type option) posted (#2) for review on master by Anonymous Coward

Comment 9975474

Date: 2016-12-12 01:27:21 -0500
From: Worker Ant <>

REVIEW: http://review.gluster.org/16098 (updated functionality of full find and incremental find) posted (#3) for review on master by Sonal Arora ([email protected])

Comment 9975475

Date: 2016-12-12 01:27:26 -0500
From: Worker Ant <>

REVIEW: http://review.gluster.org/16051 (tools/glusterfind : added --type option) posted (#3) for review on master by Sonal Arora ([email protected])

Comment 9979692

Date: 2016-12-13 01:59:23 -0500
From: Worker Ant <>

REVIEW: http://review.gluster.org/16098 (added functionality in full find to search for files (use --full --type f) or directories (use --full --type d) or both (bydefault) and in incremental find, to search files (use --type f) or directories (use --type d) or both (bydefault)) posted (#4) for review on master by Sonal Arora ([email protected])

Comment 9979693

Date: 2016-12-13 01:59:28 -0500
From: Worker Ant <>

REVIEW: http://review.gluster.org/16051 (tools/glusterfind : added --type option) posted (#4) for review on master by Sonal Arora ([email protected])

Comment 9980291

Date: 2016-12-13 05:31:22 -0500
From: Worker Ant <>

REVIEW: http://review.gluster.org/16051 (tools/glusterfind: Added functionality to filter for files or directories or both) posted (#5) for review on master by Sonal Arora ([email protected])

Comment 9980735

Date: 2016-12-13 08:02:21 -0500
From: Worker Ant <>

REVIEW: http://review.gluster.org/16051 (tools/glusterfind: Added functionality to filter for files or directories or both) posted (#6) for review on master by Sonal Arora ([email protected])

Comment 9988535

Date: 2016-12-15 01:18:06 -0500
From: Worker Ant <>

REVIEW: http://review.gluster.org/16051 (tools/glusterfind: filter for files/directories) posted (#7) for review on master by Sonal Arora ([email protected])

@gluster-ant
Copy link
Collaborator

A patch https://review.gluster.org/21965 has been posted that references this issue.

tools/glusterfind: option to display only files/directories

Updated full find to filter for files and directories.
--full --type f lists only the files,
--full --type d lists only the directories,
--full (by default) lists both files and directories.

fixes: #579
Change-Id: If2c91a21a131667d5de34635c1846013e8fa20b7
Signed-off-by: Shwetha K Acharya [email protected]

@amarts
Copy link
Member

amarts commented Jan 2, 2019

From @Shwetha-Acharya

Design:
Added an option "--type" to glusterfind to be used it with "--full" option.
Filter logic is added to selectively print the output based on the argument type.
--type f - list files only
--type d - list directories only
by default - list both files and directories.

Documentation:
1)pre command:
  Lists both files and directories in OUTFILE:
  glusterfind pre SESSION_NAME VOLUME_NAME OUTFILE

  Lists only files in OUTFILE:
  glusterfind pre SESSION_NAME VOLUME_NAME OUTFILE --type f 

  Lists only directories in OUTFILE:
  glusterfind pre SESSION_NAME VOLUME_NAME OUTFILE --type d

2)query command:
  Lists both files and directories in OUTFILE:
  glusterfind query VOLUME_NAME --full OUTFILE

  Lists only files in OUTFILE:
  glusterfind query VOLUME_NAME --full --type f OUTFILE

  Lists only directories in OUTFILE:
  glusterfind query VOLUME_NAME --full --type d OUTFILE

@amarts amarts added SpecApproved This is a mandatory flag for passing the smoke for feature. Provide spec of feature to get approval DocApproved Mandatory flag to pass smoke. Provide user facing document to get approval. labels Jan 2, 2019
@Shwetha-Acharya
Copy link
Contributor

Design:
Added an option "--type" to glusterfind to be used it with "--full" option.
Filter logic is added to selectively print the output based on the argument type.
--type f - list files only
--type d - list directories only
by default - list both files and directories.

Documentation:
1)pre command:
Lists both files and directories in OUTFILE:
glusterfind pre SESSION_NAME VOLUME_NAME OUTFILE --full

Lists only files in OUTFILE:
glusterfind pre SESSION_NAME VOLUME_NAME OUTFILE --full --type f

Lists only directories in OUTFILE:
glusterfind pre SESSION_NAME VOLUME_NAME OUTFILE --full --type d

2)query command:
Lists both files and directories in OUTFILE:
glusterfind query VOLUME_NAME --full OUTFILE

Lists only files in OUTFILE:
glusterfind query VOLUME_NAME --full --type f OUTFILE

Lists only directories in OUTFILE:
glusterfind query VOLUME_NAME --full --type d OUTFILE

@ShyamsundarR ShyamsundarR added this to the Release 6 milestone Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DocApproved Mandatory flag to pass smoke. Provide user facing document to get approval. SpecApproved This is a mandatory flag for passing the smoke for feature. Provide spec of feature to get approval
Projects
None yet
Development

No branches or pull requests

5 participants