Skip to content
This repository has been archived by the owner on May 24, 2020. It is now read-only.

Enable lvmetad and udev within the GD2 container #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kshlm
Copy link
Member

@kshlm kshlm commented Jan 10, 2019

This should help with lvm actions inside the container.

@JohnStrunk
Copy link
Member

This needs a good bit of justification.
It greatly increases the dependencies on the host environment. In order to run a gd2 pod on a given host, one must ensure lvmetad and udev are running. I don't think we can move forward with this level of dependency... We can't assume that we have a way, or privileges, to make host changes.

@kshlm kshlm added the do-not-merge indicates that PR should not be merged label Jan 11, 2019
@kshlm
Copy link
Member Author

kshlm commented Jan 11, 2019

Most modern linux hosts should have udev and lvmetad enabled by default on the host (EL7 does). This could be a problem if GCS wanted to be deployed on a cloud providers managed K8S cluster, but if someone were already using a managed K8S I don't think they'd want to manage an infrastructure part like GCS on their own.

I'm marking this as do-not-merge, but leaving it open. I mainly opened this PR because we wanted to check if using lvmetad helps with the lv operations inside the GD2 pods. We're going to re-run scale tests with this and the updated container image to see if it helps. We'll get back to the justification for this change, if it really help.

@phoenix-bjoern
Copy link

We exactly had this problem and the patch helped us to deploy GCS. We would appreciate it this PR would be merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge indicates that PR should not be merged in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants