Test preinstalled Android SDK and NDK #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| run: mvn -Pandroid gluonfx:build gluonfx:package | ||
| run: | | ||
| export ANDROID_SDK=$ANDROID_HOME | ||
| export ANDROID_NDK=$ANDROID_HOME/ndk/23.2.8568313 |
There was a problem hiding this comment.
What are the chances of Github changing this version in the future?
There was a problem hiding this comment.
Since we use ubuntu-latest, that is likely to happen, as soon as they move from 20.04 to 22 or so, possibly removing the older NDK in the process... But once that happen we'll notice and react accordingly.
There was a problem hiding this comment.
Should we hardcode the latest version for now to avoid failing the build in future?
There was a problem hiding this comment.
The latest version (25) doesn't work, that's why I'm using the older possible.
There was a problem hiding this comment.
johanvos
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1st August, NDK is set to 25, instead of 21, and that doesn't work.
This PR tries to uses NDK 23, the older version preinstalled with Ubuntu 20.04, and also prevents installing Android SDK.