Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packageType #397

Merged
merged 3 commits into from
Jan 4, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/main/java/com/gluonhq/ReleaseConfiguration.java
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,15 @@ public class ReleaseConfiguration {
public static final String DEFAULT_DEBUG_KEY_ALIAS = "androiddebugkey";
public static final String DEFAULT_DEBUG_KEY_ALIAS_PASSWORD = "android";

/**
* Type of package bundle that can be generated.
*
* - On macOS, 'pkg' or 'dmg' can be selected. Note that 'app' is generated by default.
*
* Note that on iOS 'app' and 'ipa', and Android 'apk' and 'aab', are already generated by default
*/
private String packageType;

// macOS

/**
Expand Down Expand Up @@ -175,6 +184,14 @@ public class ReleaseConfiguration {

public ReleaseConfiguration() {}

public void setPackageType(String packageType) {
this.packageType = packageType;
}

public String getPackageType() {
return packageType;
}

public boolean isMacAppStore() {
return macAppStore;
}
Expand Down Expand Up @@ -314,7 +331,8 @@ public void setProvidedKeyAliasPassword(String providedKeyAliasPassword) {
@Override
public String toString() {
return "ReleaseConfiguration{" +
"macAppStore=" + macAppStore +
"packageType=" + packageType +
", macAppStore=" + macAppStore +
", macSigningUserName=" + macSigningUserName +
", macAppCategory=" + macAppCategory +
", bundleName='" + bundleName + '\'' +
Expand All @@ -337,6 +355,7 @@ public String toString() {
public com.gluonhq.substrate.model.ReleaseConfiguration toSubstrate() {
com.gluonhq.substrate.model.ReleaseConfiguration release = new com.gluonhq.substrate.model.ReleaseConfiguration();

release.setPackageType(getPackageType());
// macOS
release.setMacAppStore(isMacAppStore());
release.setMacSigningUserName(getMacSigningUserName());
Expand Down