Make WorkspaceEdit compatible with protocol 3.0. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: the SerdeUrl/Serde<Url> can be replaced by Url once servo/rust-url#304 is merged in.
autozimu
force-pushed
the
workspaceedit
branch
from
f3b5b86 to
2a693bf
Compare
|
Thanks! I added a commit in #36 to restore the explicit url_map serialization to avoid exposing the wrapper. Since I had already done the work for the non-option map and this is the only place that it is used I just changed it to work on Option<Map<...>>. |
|
Released as 0.21.0 |
|
Make sense. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the SerdeUrl/Serde can be replaced by Url once
servo/rust-url#304 is merged in.