Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent zero-argument functions from being created in Rust #874

Merged
merged 2 commits into from
Sep 20, 2020

Conversation

Marwes
Copy link
Member

@Marwes Marwes commented Aug 19, 2020

These cannot be called from the gluon side, instead a one argument
function that takes () should be used.

bors r+

Fixes #873

bors bot added a commit that referenced this pull request Aug 19, 2020
874: fix: Prevent zero-argument functions from being created in Rust r=Marwes a=Marwes

These cannot be called from the gluon side, instead a one argument
function that takes `()` should be used.

bors r+

Fixes #873

Co-authored-by: Markus Westerlind <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 19, 2020

Build failed:

@Marwes Marwes force-pushed the zero_argument_function branch 4 times, most recently from 40ae0c0 to adb8c0b Compare September 14, 2020 18:34
These cannot be called from the gluon side, instead a one argument
function that takes `()` should be used.

Fixes gluon-lang#873
@Marwes
Copy link
Member Author

Marwes commented Sep 20, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 20, 2020

Build succeeded:

@bors bors bot merged commit c313ab8 into gluon-lang:master Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External function from Rust not being called
1 participant