Try and improve responsiveness when debounced isn't really needed #472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation for
@debounced
is to avoid many repeated updates when e.g. panning/zooming or doing other front-end changes. However, currently, there are cases where relying on debounced is not desirable, e.g.:In this case, if this code is in a cell, the figure won't be updated until after the sleep because the callback for the debounced update is not in a separate thread. The long-term fix would be to try and make sure glue and glue-jupyter are thread-safe and use a thread in this case, but for now, a simple fix is to simply treat updates in limits similarly to e.g. updates in
percentile
,cmap
and so on, and make sure those changes result in an immediate update in the figure.This PR also adds a check to avoid unnecessary repeated updates in
.update()