-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annulus draw tool #356
Annulus draw tool #356
Conversation
p.s. I am not good with the icon stuff, so if you have someone over at Glueviz that makes the proper icons, please feel free to replace the file directly on my branch or open a PR to this PR. Thanks! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
==========================================
- Coverage 89.96% 89.40% -0.57%
==========================================
Files 86 86
Lines 4523 4567 +44
==========================================
+ Hits 4069 4083 +14
- Misses 454 484 +30
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason the icon looks strange for me when using it in the regular scatter viewer (I edited the tools to add this one in to test it out):
Do you see that too or does it work ok on your side?
UI-wise, I wonder whether after the first click to select, the user should be able to then continue moving the cursor to edit the inner radius? We don't have to add it here if it's a blocker since this tool isn't enabled by default but just something to think about for future and which might be helpful in jdaviz too.
I am not surprised if it looks strange. I don't have time or interest to make pretty icon especially since Jdaviz uses its own icons anyway and we have a professional designer doing that for us. So, if you have a prettier version, please replace the one in this PR.
That could be a follow-up PR. Would be nice to be able to do that at draw time, yes, but I am just not sure what kind of click and when would be the most intuitive, so definitely need some iterations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
We need this for Imviz annulus support. This blocks:
cc @dhomeier and @astrofrog