-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed return type and shape for pixel <-> world conversions in SpectralCoordinates #82
Fixed return type and shape for pixel <-> world conversions in SpectralCoordinates #82
Conversation
Is it a concern that the CI fails here? |
Codecov ReportBase: 96.99% // Head: 97.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
+ Coverage 96.99% 97.12% +0.13%
==========================================
Files 17 18 +1
Lines 1296 1324 +28
==========================================
+ Hits 1257 1286 +29
+ Misses 39 38 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I tried this out at spacetelescope/jdaviz#1968 but now it fails with an even more obscure error:
https://github.com/spacetelescope/jdaviz/actions/runs/3959079839/jobs/6781436962 |
spectrum1d test was still expecting the old, incorrect shape. |
Oh wait... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the jdaviz
test suite for me (macos-py310), but should probably wait for @pllim's test PR to at least run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this fixes the devdeps job in Jdaviz. Thanks!
The pixel <-> world methods should return single scalars/arrays not tuples in order to be APE-14-compliant.