-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return NDData for GWCS #58
Conversation
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
==========================================
- Coverage 96.03% 95.80% -0.24%
==========================================
Files 15 15
Lines 1136 1145 +9
==========================================
+ Hits 1091 1097 +6
- Misses 45 48 +3
Continue to review full report at Codecov.
|
if isinstance(data.coords, WCS): | ||
wcs = data.coords | ||
elif type(data.coords) is Coordinates or data.coords is None: | ||
wcs = None | ||
elif isinstance(data.coords, BaseHighLevelWCS): | ||
has_gwcs = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not a general enough name as there might be other non-GWCS APE 14 WCSes. I think it would be better to special case has_fitswcs
in the first clause.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Looks good now?
instead of crashing in CCDData.
19195fc
to
7f77c19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but the test failure is related - it might just be a case of updating the test?
Re: Test failure -- I forgot to handle the case for |
|
Description
Return NDData for GWCS instead of crashing in CCDData.
This works around astropy/astropy#11727 and is a hacky version of #38.
cc @rosteen