feat: configurable max holders #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesmonty
reviewed
Dec 27, 2021
| @@ -1244,6 +1247,10 @@ pub fn execute_update_config( | |||
| config.epoch_interval = Duration::Time(epoch_interval); | |||
| } | |||
|
|
|||
| if let Some(max_holders) = max_holders { | |||
| config.max_holders = max_holders; | |||
There was a problem hiding this comment.
I think we might have a problem here. What happens if we reduce the max_holders parameter? I think it only makes sense to have an ever-increasing param, right?
There was a problem hiding this comment.
I don't think it would inherently cause any problems to reduce the max_holders parameter. Tickets held by over max_holders holders could still be held, used, and sold as usual.
As far as making sense goes, yeah it probably only makes sense to ever increase max_holders. The main exception I can think of is that if you accidentally set max_holders to a really big number, you want to be able to decrease it to a reasonable number again.
But so with that in mind yeah i'll make it only increasing and set min and max bounds for max_holders.
Ruborcalor
added a commit
that referenced
this pull request
Dec 30, 2021
* feat: increase ticket length to 6 * feat: configurable max holders (#59) * feat: make max_holders configurable * test: add test for max_holders configuration * build: build wasm and schema json artifacts * fix: add max holders bounds, make sure that max holders only increases * fix: add tests for max_holders * build: update build artifacts * Trigger actions * build: empty commit to trigger github actions
aesmonty
pushed a commit
that referenced
this pull request
Dec 30, 2021
* fix: wip prize buckets * fix: get all tests to pass * fix: add test to simulate jackpot lottery growth * fix: attempt to fix the integration test * style: use fold instead of for loop * build: update schema artifacts * fix: update integration tests to use anchor_mock * fix: pass clippy * test: update jackpot simulation outputs * test: improve jackpot simulation output * feat: add function calculate_lottery_balance * fix: update query_glow_emission_rate calculation instead of using current_prize_buckets, use lottery_balance to account for the appreciation since the last lottery * fix: update execute_epoch_ops to calculate lottery_balance * fix: update lottery balance calculation * feat: add LotteryBalance query * fix: update return type to StdResult instead of Result this way you can call calculate_lottery_balance from query_lottery_balance * fix: add LotteryBalanceResponse to lotto/examples/schema.rs * fix: pass clippy * fix: use enumerate instead of iterating over indicies * feat: increase ticket length * build: build artifacts * fix: pass clippy * fix: update oracle to use ticket length when generating hash * fix: change ticket length to 5 * test: update tests to pass * feat: update error types to give more details * fix: error message for InvalidHolderSequence * fix: pass clippy * fix: adjust pseudo_random_hash based on ticket length * fix: increase MAX_LIMIT to 10000 from 100 for prize pagination * fix: dry ticket length glow_protocol * fix: InsufficientPoolFunds pool_value value * fix: update comment describing prize_distribution * fix: update error message to specify 6 instead of 5 digits * feat: increase ticket length (#56) * feat: increase ticket length to 6 * feat: configurable max holders (#59) * feat: make max_holders configurable * test: add test for max_holders configuration * build: build wasm and schema json artifacts * fix: add max holders bounds, make sure that max holders only increases * fix: add tests for max_holders * build: update build artifacts * Trigger actions * build: empty commit to trigger github actions
Ruborcalor
added a commit
that referenced
this pull request
Apr 28, 2022
Update fee distributor README in response to questions raised in the oak-glow-v2 audit. * fix: update fee distributor README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's This
This builds off of #56 and makes it possible to configure the
max_holdersconfig.