-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable conversion warnings #809
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the core hoomd package to build warning free on gcc and clang.
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable the compiler option
-Wconversion
which is not part of-Wall
.Motivation and context
Conversion warnings notify developers when narrowing conversions may result in the loss of data. These will be important to have when we start implementing mixed precision (#355) and combinations of 16, 32, and 64 bit seeds for the RNG (#229). Just in preparing this PR to build warning free I found several bugs in memory allocators, GSD output and other places.
Unfortunately, this PR will touch many files because intended narrowing casts must be explicitly made by the developer.
This option is not part of
-Wall
so many headers and embedded libraries do not compile warning free with this option. I selectively set-Wno-conversion
on those files so we don't need to change them.How has this been tested?
I'm testing locally with gcc10 and clang11.
Change log
Checklist:
sphinx-doc/credits.rst
) in the pull request source branch.