Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dumping only part of the buffer for burst writer. #1870

Merged
merged 27 commits into from
Aug 27, 2024

Conversation

DomFijan
Copy link
Contributor

@DomFijan DomFijan commented Aug 15, 2024

Description

Adds 3 options to dump function of burst writer: start, stop and clear buffer. Start and stop determine which subset of frames will be dumped, while clear buffer flag clears the buffer or not. Default options should give same results as the current implementation.

Motivation and context

This would be very useful to have for interactivity with dupin where often we just want to dump a subset of the deque buffer of dump writer.

How has this been tested?

Tests testing new functionality have been added.

Change log

Changed:

* Add option to dump a subset of frames in burst writer
  (`#1870 <https://github.com/glotzerlab/hoomd-blue/pull/1870>`__)

Checklist:

@DomFijan DomFijan changed the base branch from trunk-patch to trunk-minor August 15, 2024 16:37
@DomFijan DomFijan marked this pull request as ready for review August 17, 2024 06:19
When the whole buffer is not cleared, only part of the buffer up until the last frame that was written is cleared instead
hoomd/GSDDequeWriter.cc Show resolved Hide resolved
hoomd/GSDDequeWriter.h Outdated Show resolved Hide resolved
@joaander joaander added the validate Execute long running validation tests on pull requests label Aug 26, 2024
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joaander joaander merged commit bcc61f0 into trunk-minor Aug 27, 2024
35 checks passed
@joaander joaander deleted the feat_burst_dump_range branch August 27, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validate Execute long running validation tests on pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants