Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide full CUDA errors for device scan messages. #1803

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

joaander
Copy link
Member

@joaander joaander commented Jun 6, 2024

Description

Provide full CUDA errors for device scan messages.

Motivation and context

HIP errors state "Unknown error" for almost every CUDA error. This does not help users.

How has this been tested?

CI checks.

Change log

Changed:

* Provide the full CUDA error message when scanning devices
  (`#1803 <https://github.com/glotzerlab/hoomd-blue/pull/1803>`__).

Checklist:

@joaander joaander requested review from a team, tcmoore3, SchoeniPhlippsn and AlainKadar and removed request for a team June 6, 2024 21:00
@joaander joaander added the validate Execute long running validation tests on pull requests label Jun 6, 2024
@joaander
Copy link
Member Author

While this does not provide a better message in #1802 as I hoped, the code does work and may provide a better message for someone in the future. I tested it by triggering an error manually before the message is formatted.

@joaander joaander merged commit 088b854 into trunk-patch Jun 10, 2024
45 of 57 checks passed
@joaander joaander deleted the num-devices-errors branch June 10, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validate Execute long running validation tests on pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant