Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the box1 box2 arguments to BoxResize. #1740

Merged
merged 7 commits into from
Mar 13, 2024

Conversation

joaander
Copy link
Member

Description

Add the box argument to BoxResize. Deprecate box1, box2, and variant.

Motivation and context

Box variants provide a more flexible solution.

Resolves #1640

How has this been tested?

Added unit tests.

Change log

Added:

* ``box`` argument to ``hoomd.update.BoxResize`` that accepts a ``BoxVariant``.

Deprecated:

* ``box1``, ``box2``, and ``variant`` arguments to ``hoomd.update.BoxResize``.

Checklist:

@joaander joaander requested review from a team, tcmoore3, SchoeniPhlippsn and pepak13 and removed request for a team March 12, 2024 18:46
Base automatically changed from feature/quick-compress-moving-target-box to trunk-minor March 12, 2024 18:50
@joaander joaander added the validate Execute long running validation tests on pull requests label Mar 12, 2024
Copy link
Member

@tcmoore3 tcmoore3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tcmoore3
Copy link
Member

pytest is failing because variant.box.Interpolate is not pickleable because I didn't add a __reduce__ method in #1736 like I did for variant.box.Constant. I will add one shortly if it's not there before I can get to it.

@joaander joaander merged commit aae100c into trunk-minor Mar 13, 2024
40 checks passed
@joaander joaander deleted the deprecate-box1-box2 branch March 13, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validate Execute long running validation tests on pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants