-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove custom action methods #1699
Conversation
The pytest failed at |
You can remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the changelog need to be updated to say these methods were removed?
Yes. I handle changelog updates separately from pull requests in HOOMD-blue and will add this at some point after the PR is merged. What does need to be added to this PR is an update to |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
Removed the following methods in a branch off
trunk-major
after adding deprecation warnings in #1692_InternalCustomUpdater.update
._InternalCustomTuner.tune
._InternalCustomWriter.write
.HDF5Log.write
.Motivation and context
Resolves #1648
How has this been tested?
Ran python tests on all the hoomd files, removed the wrap action act method in
custom_operation.py
to avoid the test calling the operation function and introduce error.Change log
Checklist:
sphinx-doc/credits.rst
) in the pull request source branch.