External magnetic field #1637
Merged
External magnetic field #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 11, 2023 13:12
SchoeniPhlippsn
requested review from
a team,
tcmoore3 and
syjlee
and removed request for
a team
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
tcmoore3
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Nice work. I was able to build and test the branch and it seems to work as expected.
It looks like you need to add the new python class to the doc pages so that it shows in the sphinx documentation. There are also some flake8 errors to fix. Otherwise this should be good to go.
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…ab/hoomd-blue into external_magnetic_field
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
joaander
added
the
validate
|
I fixed the readthedocs webhook and docs are now building again. This is failing with: |
…ab/hoomd-blue into external_magnetic_field
Also test documentation code snippets.
joaander
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new constant magnetic field that acts on magnetic dipoles.
Motivation and context
Allows for a coupling between magnetic particles and an external magnetic field.
How has this been tested?
I added pytests and tested it on different systems both using CPU and GPU.
Change log
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.