Fix/hdf5 scalar detection #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-butler
requested review from
a team,
tcmoore3 and
rayasare
and removed request for
a team
|
will have to take a look at this after Friday |
joaander
added
the
validate
joaander
reviewed
Sep 25, 2023
tcmoore3
approved these changes
Sep 25, 2023
rayasare
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves and corrects
hoomd.write.HDF5Log's detection of scalar value types and converts to the appropriate NumPy dtype.Motivation and context
Resolves #1620
How has this been tested?
An appropriate test was added to validate the typing behavior.
Change log
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.