Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed unused ExternalFieldComposite #1604

Merged
merged 1 commit into from
Aug 17, 2023
Merged

removed unused ExternalFieldComposite #1604

merged 1 commit into from
Aug 17, 2023

Conversation

melodyyzh
Copy link
Contributor

Description

Deleted ExternalFieldComposite.h and modified all files that include ExternalFieldComposite.h and containsExternalFieldComposite*.

Motivation and context

Resolves #1555

How has this been tested?

Used pytest to test all the files in hoomd/hpmc

Change log

Removed `ExternalFieldComposite.h` and all the related `ExternalFieldComposite*`.

Checklist:

@melodyyzh melodyyzh requested review from a team, b-butler, pepak13 and joaander and removed request for a team August 11, 2023 08:18
@melodyyzh melodyyzh added the validate Execute long running validation tests on pull requests label Aug 11, 2023
b-butler
b-butler approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@b-butler b-butler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @melodyyzh!

@joaander joaander changed the base branch from trunk-major to trunk-minor August 14, 2023 11:21
pepak13
pepak13 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@pepak13 pepak13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@joaander joaander merged commit 289d9a0 into trunk-minor Aug 17, 2023
70 of 71 checks passed
@joaander joaander deleted the remove_ExternalFieldComposite branch August 17, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepak13 pepak13 pepak13 approved these changes

@b-butler b-butler b-butler approved these changes

@joaander joaander Awaiting requested review from joaander

Assignees
No one assigned
Labels
validate Execute long running validation tests on pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@melodyyzh @b-butler @pepak13 @joaander