Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake error when using HIP. #1579

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Fix CMake error when using HIP. #1579

merged 1 commit into from
Jun 21, 2023

Conversation

joaander
Copy link
Member

Description

Call find_package_handle_standard_args only when there are required libraries found.

Motivation and context

Prior to this change, CMake reports an error that the REQUIRED_VARS argument is missing. Nowhere does this script set REQUIRED_HIP_LIB_VARS, so ${REQUIRED_HIP_LIB_VARS} is the empty string.

How has this been tested?

This branch builds on Frontier.

Change log

Fixed:

* CMake error when ``HOOMD_GPU_PLATFORM=HIP``.

Checklist:

@joaander joaander requested review from a team, tommy-waltmann and rayasare and removed request for a team June 20, 2023 20:56
@joaander joaander added the validate Execute long running validation tests on pull requests label Jun 20, 2023
@joaander joaander merged commit 741cb4d into trunk-patch Jun 21, 2023
@joaander joaander deleted the fix-frontier-cmake branch June 21, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validate Execute long running validation tests on pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants