Fix builds with ROCM 5.1.0. #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classes with virtual methods must have virtual destructors. The cray compiler environment issues a warning here.
The cray compiler environment issues this style warning when building hoomd. Ignore the warning in place of rewriting major portions of the vendored random123.
hipcc is more stringent on requiring this than nvcc.
This change is necessary so that CMake processes the .cu files with hipcc.
NVCC is specific to the nvcc compiler, whereas __HIPCC__ is defined by HIP in both nvcc and hipcc.
rocm does not provide a compatible cusparse library. Move the preprocessor definitions so that this legacy code is only included in nvcc builds.
joaander
requested review from
a team,
b-butler and
pepak13
and removed request for
a team
|
glotzerlab/software#263 includes the install script for the Crusher build environment. |
joaander
added
validate
|
#1479 documents the seg fault. |
|
@pepak13 Let me know what you think. |
pepak13
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make all changes needed to build HOOMD against ROCM 5.1.0.
Motivation and context
These changes allow HOOMD to run on OLCF Crusher, the test system for Frontier.
How has this been tested?
I executed the unit tests (ctest and pytest). The core and md test pass. I'm getting seg faults in the HPMC tests. Our immediate need is for MD simulations on Frontier, so let's merge this set of fixes now. I will revisit HPMC support in a later PR.
Change log
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.