Exclude twine==5.1.0 and set --strict
#992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5.1.0 has a bug with how it interacts with `importlib_metadata>=8.0`. A fix is in progress, but it's not clear when it will be released (probably soon).
sirosen
requested review from
aaschaer,
ada-globus,
derek-globus and
kurtmckee
as code owners
aaschaer
approved these changes
Jun 26, 2024
kurtmckee
approved these changes
Jun 26, 2024
|
Got a link to the associated twine PR / bug report? I don't know which one to link from here... |
|
I think I would crosslink with pypa/twine#977 It's fixed and merged but not yet released for twine. |
|
twine 5.1.1 is already released with the fix. Available on pypi. https://pypi.org/project/twine/ |
|
Thanks @JohnVillalovos! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.1.0 has a bug with how it interacts with
importlib_metadata>=8.0.A fix is in progress, but it's not clear when it will be released (probably soon).
📚 Documentation preview 📚: https://globus-sdk-python--992.org.readthedocs.build/en/992/