Add 'query_params' to token introspect #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a passthrough to allow arbitrary parameter passthrough. It is being added based on a conversation with the Auth team indicating that introspect may support query parameters in the future, and that this passthrough will be useful for development of such parameters. Importantly, this adds two tests + test data for introspect, to ensure that passing no values for query params does not send query params, and that params can be passed successfully.
sirosen
requested review from
aaschaer,
ada-globus,
derek-globus and
kurtmckee
as code owners
derek-globus
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a passthrough to allow arbitrary parameter passthrough. It is
being added based on a conversation with the Auth team indicating that
introspect may support query parameters in the future, and that this
passthrough will be useful for development of such parameters.
Importantly, this adds two tests + test data for introspect, to ensure
that passing no values for query params does not send query params,
and that params can be passed successfully.
📚 Documentation preview 📚: https://globus-sdk-python--984.org.readthedocs.build/en/984/