Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non experimental scope parsing sc 30765 #966

Merged

Conversation

derek-globus
Copy link
Contributor

@derek-globus derek-globus commented Mar 22, 2024

What?

  1. Move Scope out of experimental
  2. Remove Scope contains function
  3. Remove Scope benchmarking script

Why?

  1. It's sat in experimental long enough for us to be comfortable that the interface won't change in impactful ways.
  2. contains was a good objective but conveys too much semantically about what is being evaluated
  3. This was already run against the scope construct. If we want to run it again, we can revive it from github history.

📚 Documentation preview 📚: https://globus-sdk-python--966.org.readthedocs.build/en/966/

Copy link
Member

@sirosen sirosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we move this forward, I think we need to make sure that Scope objects -- both singular and plural as contained in a list -- work as inputs to methods which take strings or MutableScope objects as their inputs.

Primarily, I'm thinking of the requested_scopes=... parameters for OAuth2 flows, but there might be other things I'm forgetting.

@derek-globus
Copy link
Contributor Author

Before we move this forward, I think we need to make sure that Scope objects -- both singular and plural as contained in a list -- work as inputs to methods which take strings or MutableScope objects as their inputs.
Primarily, I'm thinking of the requested_scopes=... parameters for OAuth2 flows, but there might be other things I'm forgetting.

Agreed but splitting this off into it's own bucket of work.

@sirosen
Copy link
Member

sirosen commented Apr 1, 2024

Per our conversation, we're dropping any notion that this PR is going to handle updating the ScopeCollectionType to include Scope. We'll do that in a fast-follow PR (which should be quite easy!).

@derek-globus derek-globus merged commit f60c9a3 into globus:main Apr 1, 2024
16 checks passed
@derek-globus derek-globus deleted the non-experimental-scope-parsing-sc-30765 branch April 1, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants