Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefill_named_grant when set via GlobusApp #1075

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

sirosen
Copy link
Member

@sirosen sirosen commented Oct 4, 2024

This uses a "nice" format of <app> on <host>. e.g.,

sample-script on porgy-and-bess

Where app_name="sample-script" and the hostname is
"porgy-and-bess".


📚 Documentation preview 📚: https://globus-sdk-python--1075.org.readthedocs.build/en/1075/

This uses a "nice" format of `<app> on <host>`. e.g.,

    sample-script on porgy-and-bess

Where `app_name="sample-script"` and the hostname is
`"porgy-and-bess"`.
Copy link
Contributor

@ada-globus ada-globus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving under the presumption that this was the agreed outcome of the discussion around how to handle this (since IIRC there was some disagreement). I'm a strong 👍 for use of the hostname.

@sirosen
Copy link
Member Author

sirosen commented Oct 7, 2024

Yeah, this is where the discussion landed. Also, I'm pretty sure this won't conflict with other work, so I'm going ahead with the merge.

@sirosen sirosen merged commit ada2f72 into globus:main Oct 7, 2024
17 checks passed
@sirosen sirosen deleted the fix-prefill-named-grant branch October 7, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants