Add UUID checking for add_app_data_access_scope #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to help users catch avoidable errors during login flows, this adds a validation check which confirms that the UUID given to `add_app_data_access_scope` is a valid UUID str. It also checks type -- guarding against `None` producing strings like `.../None/data_access` and similar type errors. The check is defined in the utils module for potential reuse, but no extra usage sites are added in this changeset.
sirosen
requested review from
aaschaer,
ada-globus,
derek-globus and
kurtmckee
as code owners
derek-globus
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to help users catch avoidable errors during login flows, this
adds a validation check which confirms that the UUID given to
add_app_data_access_scopeis a valid UUID str. It also checks type-- guarding against
Noneproducing strings like.../None/data_accessand similar type errors.The check is defined in the utils module for potential reuse, but no
extra usage sites are added in this changeset.
📚 Documentation preview 📚: https://globus-sdk-python--1022.org.readthedocs.build/en/1022/